[#41160] - [4.3] Guided Tours - Eliminate tour blur event errors
- Fixed in Code Base
- 20 Jul 2023
- Medium
- Build: 4.3-dev
- # 41160
- Diff
- GeraintEdwards:tours4.3-blur
User tests: Successful: Unsuccessful:
Resubmission of PR #41159 for Joomla 4.3 instead
When you complete a tour and then interact with a targeted element the blur event listener is still attached and throws a javascript error
Pull Request for Issue # .
Summary of Changes
Check there is a tour active before attempting to focus on the tour step buttons
Testing Instructions
Run a tour e.g. How to create a menu item - cancel the tour before completing the title step (the same problem can exist in a completed tour).
Click in the 'title' field and then move it out (i.e. fire a blur event) the view the javascript console
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No error message in the console.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41160.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41160.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-20 22:27:02 |
| Closed_By | ⇒ | obuisard |
Thank you Geraint @GeraintEdwards for the PR!
I have tested this item✅ successfully on 753db7a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41160.