[#41155] - [4.3] Record currentStepId in sessionStorage when responding to an interaction
- Fixed in Code Base
- 18 Jul 2023
- Medium
- Build: 4.3-dev
- # 41155
- Diff
- GeraintEdwards:tour1-4.3
User tests: Successful: Unsuccessful:
Please see equivalent PR for Joomla 5 at #40776
Pull Request for Issue # .
Summary of Changes
Change handling of 'button' interactive type to respond to the button click rather than immediately executing.
This execution happens at the start of the tour and not when the step has actually been reached and so the modal setup ends up being called twice. As a result other steps with interactive actions e.g. checkboxes or text input fields cannot be interacted with.
Testing Instructions
Create a tour as per following screenshots - a JSON import is attached if you have implemented the tours import/export PR #40645
Unpublish steps 3 and 4 so that you have this as an overview
Now run the tour
Actual result BEFORE applying this Pull Request
At step 2 you have a double backdrop and can't interact with the checkbox
If you enable steps 3 and 4 it behaves even worse
and if you proceed with clicking the rebuild button you get stuck in a loop.
Expected result AFTER applying this Pull Request
You also don't get a loop on the rebuild button action step
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
[x ] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[ x] No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41155.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41155.
What happens when you navigate backwards?
What happens when you navigate backwards?
@brianteeman You mean with the „back“ button of the browser?
no I mean the back button in the tour
no I mean the back button in the tour
It is well behaved in my tests - did you see a problem? Can you should how to recreate it and I'll investigate.
p.s. Another of my PRs (for Joomla 5 at least) resolves the problem with orphan steps when you bit the browser back button e.g. in the middle of the article creation tour.
| Labels |
Added:
?
bug
|
||
It is well behaved in my tests - did you see a problem? Can you should how to recreate it and I'll investigate.
didnt test it just wanted to makie sure it was handled
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-18 17:10:33 |
| Closed_By | ⇒ | obuisard |
Thanks Geraint @GeraintEdwards for the PR!
I have tested this item✅ successfully on a40e388
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41155.