Joomla! Issue Tracker | Joomla! CMS #41127

bug PR-4.4-dev

Fixed in Code Base
23 Jul 2023
Medium
Build: 4.4-dev
# 41127
Diff
alikon:patch-19

Pending

User tests: Successful: Unsuccessful:

alikon
8 Jul 2023

Pull Request for Issue #41125 .

Summary of Changes

delete if exists

Testing Instructions

see #41125

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

1275fd2 8 Jul 2023

isfile

joomla-cms-bot - change - 8 Jul 2023

Category

⇒

Administration com_joomlaupdate

alikon - change - 8 Jul 2023

Status

New

⇒

Pending

alikon - open - 8 Jul 2023

brianteeman - test_item - 8 Jul 2023 - Tested successfully

brianteeman - comment - 8 Jul 2023

I have tested this item ✅ successfully on 1275fd2

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41127.}

richard67 - comment - 8 Jul 2023

@alikon The update succeeds with this PR, but I still get a PHP notice:

PHP Notice:  Indirect modification of overloaded property Joomla\\CMS\\Http\\Response::$body has no effect in /home/richard/lamp/public_html/joomla-cms-4.4-dev/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php on line 498

I think it needs a similar modification for that code line here

joomla-cms/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php

Line 498 in 1275fd2

File::write($target, $result->body);

as you have done with your other PR #41127 for the CLI here:

joomla-cms/libraries/src/Installer/InstallerHelper.php

Lines 121 to 125 in 46534b9

    
           // Fix Indirect Modification of Overloaded Property 
        
           $body = $response->body; 
        
           // Write buffer to file 
        
           File::write($target, $body);

Would it make sense to fix that with this PR here, too?

ad21910 8 Jul 2023

notice

alikon - change - 8 Jul 2023

Labels

Added: PR-4.4-dev

alikon - comment - 8 Jul 2023

done

3309ffc 8 Jul 2023

Update administrator/components/com_joomlaupdate/src/Model/UpdateModel.php

richard67 - test_item - 8 Jul 2023 - Tested successfully

richard67 - comment - 8 Jul 2023

I have tested this item ✅ successfully on 3309ffc

Hint for other testers: For testing the fix I've updated from a 4.4-dev with this PR applied to a 5.0-dev package where this PR has been merged into.

You can find such a package at https://test5.richard-fath.de/Joomla_5.0.0-alpha3-dev-Development-Update_Package_2023-07-10_test-pr-41127.zip , and you can use the custom update URL https://test5.richard-fath.de/next_major_list_test-pr-41127.xml to update to that package.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41127.}

richard67 - comment - 8 Jul 2023

@brianteeman Could you repeat your test with the latest changes? Thanks in advance.

ab4f49e 23 Jul 2023