? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar jurihahn
jurihahn
7 Jul 2023

Pull Request

Summary of Changes

"onchange" event don't work on color form field. If I add

<field
	name="my_color"
	type="color"
	control="advanced"
	onchange="alert('color changed');"
/>

I get result HTML result:
<input type="text" name="my_color" ... data-control="advanced" alert('color="" changed');="" data-format="hex" size="7">

Testing Instructions

Create form with color form field and add custom "onchange" for example onchange="alert('color changed');" then load page with this form and select any color

Actual result BEFORE applying this Pull Request

you don't get message "color changed"

Expected result AFTER applying this Pull Request

you get message "color changed"

avatar joomla-cms-bot joomla-cms-bot - change - 7 Jul 2023
Category Layout
avatar jurihahn jurihahn - open - 7 Jul 2023
avatar jurihahn jurihahn - change - 7 Jul 2023
Status New Pending
avatar Quy Quy - test_item - 7 Jul 2023 - Tested successfully
avatar Quy
Quy - comment - 7 Jul 2023

I have tested this item successfully on 9193822


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41126.

avatar viocassel viocassel - test_item - 8 Jul 2023 - Tested successfully
avatar viocassel
viocassel - comment - 8 Jul 2023

I have tested this item successfully on 9193822


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41126.

avatar alikon alikon - change - 8 Jul 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 8 Jul 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41126.

avatar jurihahn jurihahn - change - 13 Jul 2023
Labels Added: ? PR-4.3-dev
avatar obuisard obuisard - change - 14 Jul 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-07-14 18:56:10
Closed_By obuisard
avatar obuisard obuisard - close - 14 Jul 2023
avatar obuisard obuisard - merge - 14 Jul 2023
avatar obuisard
obuisard - comment - 14 Jul 2023

Thank you Juri @jurihahn for the PR!

Add a Comment

Login with GitHub to post a comment