[#41101] - [4.4] Bootstrap 5.3
- Fixed in Code Base
- 23 Jul 2023
- Medium
- Build: 4.4-dev
- # 41101
- Diff
- wilsonge:bootstrap-53
User tests: Successful: Unsuccessful:
Summary of Changes
Upgrades to bootstrap 5.3. This isn't 100% b/c but its as b/c as I can make it. The biggest issue is that bootstrap introduced a --link-color parameter that a) causes various parts of our code to not compile and b) does the same thing as our template-link-color/casseopia-color-link EVs. I've tried to migrate our usage to the new BS variable - but also keep us setting the old variables for templates that depend on them.
Note as this is a first pass I'm deliberately disabling dark mode support for now. This should be enabled but will require another pass over our SCSS and I'd rather just get the dependency upgrade in for now before enabling the shiny new features.
Testing Instructions
Check core loads and styling works as expected in both frontend and backend. If you have any extensions to hand ideally check that their styling also continue to work.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change Installation Front End Templates (site) |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
can we get some progress here please I would like to have this merged so george can continue with the bs5.3 integration in to j5
| Labels |
Added:
NPM Resource Changed
PR-4.4-dev
|
||
Edit an article.
See no borders.
See no borders.
@wilsonge diff the choices.css from https://github.com/dgrammatiko/muta/blob/main/media_source/templates/administrator/muta/scss/vendor/choicesjs/choices.scss
probably these lines: https://github.com/dgrammatiko/muta/blob/36a98876000064ec3396ede9d739b4f757c14183/media_source/templates/administrator/muta/scss/vendor/choicesjs/choices.scss#L402
See no borders.
@wilsonge diff the choices.css from https://github.com/dgrammatiko/muta/blob/main/media_source/templates/administrator/muta/scss/vendor/choicesjs/choices.scss
probably these lines: https://github.com/dgrammatiko/muta/blob/36a98876000064ec3396ede9d739b4f757c14183/media_source/templates/administrator/muta/scss/vendor/choicesjs/choices.scss#L402
this is also in the current version? or should it be removed?
Color is lighter than before.
The borders is because it’s not pulling through the prefix variable and using the css variables with the -bs prefix. Not really sure why right now (I mean even after moving the prefix declaration into the variables.scss from the template file so it’s actually imported)
@wilsonge the border is defined here: https://github.com/twbs/bootstrap/blob/8fcfce1ebd988fd4e5ed2f51acaa5c49e6b301c9/scss/_variables.scss#L904
and the select tags use it here: https://github.com/twbs/bootstrap/blob/8fcfce1ebd988fd4e5ed2f51acaa5c49e6b301c9/scss/_variables.scss#L1020
Try to move the input section before the select section: this
Also it might need a fallback value as all the --template-* are defined after the template.css has been loaded (using a style tag). I might be wrong tho...
I would like to have this one in the upcoming 4.4 alpha 3. Is it possible for tomorrow ?
I will try and fix this evening but I need to figure out the root cause. My recommendation is you merge it anyhow if it’s just choices borders that have a problem and I’ll commit to having a fix early next week. Even if it’s post alpha release we can just add it as a known issue to the release notes. Better to get people testing with it listed as known than to delay general testing another few weeks
Thank you
OK So the missing border on choices is fixed. The color change on the checkboxes is just part of the dark mode changes they made (yes I know we aren't using dark mode but the border changed as part of that PR), obviously we can override the default too if we want something closer to the original
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-23 09:48:54 |
| Closed_By | ⇒ | MacJoom |
re the changes in the cassiopeia php files for the atum variables. They are not needed as they are no used - see #41054