[#41098] - [5.0] Joomla Update: Improve progress bar display
- Fixed in Code Base
- 1 Jul 2023
- Medium
- Build: 5.0-dev
- # 41098
- Diff
- Hackwar:5.0-joomlaupdate-3
User tests: Successful: Unsuccessful:
Set progress to 80% for extraction and 100% after finalisation
Pull Request for Issue # .
Summary of Changes
It seems as if several people have issues with the update process because the progressbar shows 100% at the end of extracting the files and only then does the finalisation step, which can take several seconds. Users don't know that something is happening in the background and then navigate away from the page, cancelling the request and thus the finalisation step. This PR tries to get around that by pinning the progressbar to 80% at the end of the extraction process and then only update the progressbar to 100% when the finalisation step is done, waiting one second to display that to people and only then to redirect away from the page.
Testing Instructions
Update Joomla and see the changed behavior of the progressbar.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-01 13:25:56 |
| Closed_By | ⇒ | HLeithner |
thanks
I have tested this item ✅ successfully on 25e725f
I've successfully tested that this PR does what it claims to do and verified that there are no error in the browser console or PHP.
However, it's worth a question if we should apply this change on 4.4-dev, too, or apply it only there and merge it up to 5.0-dev.
When we update from 4.4 to 5.0, the js loaded by the browser is still the one from 4.4, as far as I know, and the extract.php which runs is also the one from 4.4, I think.
So when we apply the changes from here we will only benefit from it when updating e.g. from 5.0.0 to 5.0.1 or later 6.0.
But the issue solved by this PR becomes more critical the more database updates and other stuff happens, which is more when we update from 4.4.
Currently we don't have so many database changes in 5.0, but that might change, and we also have and will have more migrations of plugin parameters. So an update from 4.4 to 5.0 will definitely need more time for the finalization.
Therefore I think we should apply this change already to 4.4-dev so we have the full benefit for sure when updating from 4.4 to 5.0.
Hint for other testers: First apply the changes of this PR and compile the js, then update to the patched package or custom update URL created by Drone for this PR here. You need to watch carefully the progress bar and the text above it to see that when the finalization starts the bar is at 80% and then quickly goes to 100% when the finalization has finished.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41098.