PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
26 Jun 2023

Summary of Changes

Changes the canDo ACL checks in views to Registry. Internally a State class is used for 100% backwards compatibility.

Testing Instructions

Open the following form views:

  • Banners client
  • Any category
  • Fields field
  • Fields groups

Actual result BEFORE applying this Pull Request

All action bar buttons are shown.

Expected result AFTER applying this Pull Request

All action bar buttons are shown.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#176

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Jun 2023
Category Administration com_banners com_categories com_fields com_finder com_languages com_menus com_modules com_newsfeeds com_tags com_templates com_users Libraries
avatar laoneo laoneo - open - 26 Jun 2023
avatar laoneo laoneo - change - 26 Jun 2023
Status New Pending
ccccbdf 26 Jun 2023 avatar laoneo more
avatar laoneo laoneo - change - 26 Jun 2023
Labels Added: PR-5.0-dev
avatar wilsonge
wilsonge - comment - 26 Jun 2023

Please don’t mix model state into this! If we need a b/c class create something else even if a duplicate. Or don’t call it state and put it in the model folder

avatar laoneo
laoneo - comment - 27 Jun 2023

Fair enough, was a bit lazy ?‍♂️

avatar laoneo laoneo - change - 28 Jun 2023
Title
Change can do to Registry
[5.0] Change can do to Registry
avatar laoneo laoneo - edited - 28 Jun 2023
avatar HLeithner HLeithner - close - 21 Aug 2023
avatar HLeithner HLeithner - merge - 21 Aug 2023
avatar HLeithner HLeithner - change - 21 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-21 06:37:36
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 21 Aug 2023

Thanks can you add a b/c change entry to the manual please

avatar laoneo laoneo - change - 22 Aug 2023
The description was changed
avatar laoneo laoneo - edited - 22 Aug 2023
avatar laoneo
laoneo - comment - 22 Aug 2023

Manual entry joomla/Manual#176

Add a Comment

Login with GitHub to post a comment