[#41055] - [5.0] Return a registry in button plugins
- Closed
- 21 Aug 2023
- Medium
- Build: 5.0-dev
- # 41055
- Diff
- Digital-Peak:buttons/registry
User tests: Successful: Unsuccessful:
Summary of Changes
Editor buttons should return a Registry object instead of CMSObject. CMSObject buttons are still supported.
Testing Instructions
Open the article form and add some images though the editor buttons or a readmore divider.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
| Category | Libraries Front End Plugins | ⇒ | Libraries Front End Plugins Unit Tests |
| Labels |
Added:
?
|
||
| Title |
|
||||||
I merged the Event PR, because I think it's more important to use our event system correctly. If this pr still make sense in another way please rebase it. thanks
This one doesn't make then any sense as the usage of CMSObject is deprecated now for buttons.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-21 07:14:21 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Sorry, I do not approve it
There a PR for this issue #40082 which introduce
Joomla\CMS\Editor\Button\ButtonBut if that PR will be rejected then this one PR is fine :)