[#4103] - Improve handling of "Date of Birth" (dob) infotext in user profile plugin
- Closed
- 28 Oct 2014
- Medium
- Build: staging
- # 4103
- Diff
- Bakual:dob
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue
Currently, the user - profile plugin uses a separate spacer field to display an info text for the "date of birth" (dob) field.
This makes it necessary to add some specific codechecks for when that spacer field should be shown or hidden. Like done in #4043.
Proposal
This PR moves the dob field and the infotext into a custom formfield and removes the special code for the dob_spacer field.
Questions
While trying this solution I wondered why we even have this info text separated. I think best place would actually be the tooltip, which is exactly meant for that kind of information.
The plugin currently overrides the description set in the profile.xml with a hardcoded and quite useless text. I'm not sure why that is but I guess it's for historical reasons, maybe before there was a separate profile.xml file?
Does anyone know why this was done like this?
jissues-bot
- | Status | Pending | ⇒ | New |
| Labels |
Added:
?
?
|
||
Questions
While trying this solution I wondered why we even have this info text separated. I think best place would actually be the tooltip, which is exactly meant for that kind of information.
The plugin currently overrides the description set in the profile.xml with a hardcoded and quite useless text. I'm not sure why that is but I guess it's for historical reasons, maybe before there was a separate profile.xml file?
Does anyone know why this was done like this?
The point was that a new user registering may not even notice we have Tooltips. As we had many reports of people entering wrong date formats, we added the spacer. It is not there because of history.
Moved the markup into a new JLayout. That should allow a template to adjust it if this doesn't work due to overrides.
| Title |
|
||||||
nicksavov
- | Labels |
Removed:
?
|
||
brianteeman
- | Status | New | ⇒ | Pending |
| Category | ⇒ | Plugins |
| Status | Pending | ⇒ | Ready to Commit |
moving to RTC since @infograf768 and i test this successful thanks @Bakual
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4103.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-28 07:04:26 |
test: nice!