No Code Attached Yet
avatar cozioscob
cozioscob
21 Jun 2023

Steps to reproduce the issue

Banner component & module 'Select By Keyword' not working if there is No Client selected. e.g. adding keyword 'all' to an article and adding the same keyword to a related banner while choosing 'No Client' in the module results in no banner showing.

Expected result

Banner is shown when 'No Client' is selected and Select By Keyword is selected

Actual result

Banner is not shown

Additional comments

As per conversation in #40987 and initially raised in #39016
Error with no client selected is
Warning: Undefined array key 4 in ----/public_html/components/com_banners/src/Model/BannersModel.php on line 231
Also showing a 1064 error on the homepage only of my particular site, screengrab attached (other pages no error unless debug is on and max error reporting, banner just doesn't show.
Screenshot 2023-06-21 at 13 18 43

avatar cozioscob cozioscob - open - 21 Jun 2023
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jun 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Jun 2023
avatar MacJoom
MacJoom - comment - 22 Jun 2023

I can confirm the issue - apart from the 1064 error - most likely a mysql error visible only on your host ,since the query was not built properly - see fix in #39016

avatar alikon
alikon - comment - 22 Jun 2023

@MacJoom so we can close this one for #40996 ?

avatar MacJoom
MacJoom - comment - 22 Jun 2023

yesss please

avatar alikon alikon - close - 22 Jun 2023
avatar alikon
alikon - comment - 22 Jun 2023

please test #39016

avatar alikon alikon - change - 22 Jun 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-06-22 12:28:32
Closed_By alikon

Add a Comment

Login with GitHub to post a comment