Thanks @PhocaCz can you also add a @param description to the doc block?

Added @param

Found that the javascript function takes as an argument form element not id of element, so added pull request to change the javascript: PhocaCz@391e41c

@PhocaCz if we change the core-uncompressed.js we also need to update the core.js with this changes.

Hi, yes, core.js needs to be changed - not sure how this works, but I thought, core.js is automatically converted from core-uncomressed.js.

Anyway the patch is working Ok when testing but of course it is not a clean solution, because the "form" as parameter in the javascript function in fact is not clearly defined - it can be an element or string. I think, it is better to have the parameter as a string as you can get the element every time you need in the function body. Now you have problems to send the element as parameter (e.g. when using inline javascript - for example: grid.php). It is better to send the name which then becomes element by getelementbyid function. Unfortunately changing it to string and making it easier and cleaner (from my point of view) can cause backward compatibility issues, so the patch is made to not break the backward compatibility.

Jan

Hi, yes, core.js needs to be changed - not sure how this works, but I thought, core.js is automatically converted from core-uncomressed.js.

We don't have an automatic compression yet. You just manually compress it using your favorite tool and add it to the PR.

Aha, please can you let me know some compress tool - I don't have any experiences regarding compressing :-(

Thank you, Jan

I think last time I used http://refresh-sf.com/yui/. But there are at least hundreds of them
https://www.google.ch/search?q=js+compress+online#q=js+compressor+online

Hi, thank you for the link, sorry for delay:
#4121

Please check #4236 which contains initial contribution + some optimisations & compressed file.