Feeling Lucky
?
PR-4.4-dev
[#40764] - Edit/cypress port
- Fixed in Code Base
- 14 Jun 2023
- Medium
- Build: 4.3-dev
- # 40764
- Diff
- andyforrest:edit/cypress-port
User tests: Successful: Unsuccessful:
Summary of Changes
Added db_port to cypress.config.dist.js to avoid any potential issues with cy.task('queryDB')
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql com_banners com_categories com_config com_contact com_content com_contenthistory com_finder |
| Status | New | ⇒ | Pending |
richard67
- comment
- 14 Jun 2023
@andyforrest I see you just fixed it, all good. Thanks.
| Category | Unit Tests Repository Administration com_admin SQL Postgresql com_banners com_categories com_config com_contact com_content com_contenthistory com_finder | ⇒ | JavaScript Unit Tests |
| Labels |
Added:
?
PR-4.4-dev
|
||
laoneo
- comment
- 14 Jun 2023
Thanks, can you add the port argument also to the postgres connection, we are using this library https://github.com/porsager/postgres#connection.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-14 14:18:11 |
| Closed_By | ⇒ | laoneo |
laoneo
- comment
- 14 Jun 2023
Thanks, looking good!
@andyforrest Can it be that you have chosen the wrong base branch for this PR? GitHub shows a lot of differences. Maybe you anted to make this PR not for the 4.3-dev branch but for 4.4-dev or 5.0-dev? If that is the case you can switch the base branch by using the edit button beside the title of this pull request on GitHub. Let me know when you need help with that. Thanks in advance.