? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar andyforrest
andyforrest
14 Jun 2023

Summary of Changes

Added db_port to cypress.config.dist.js to avoid any potential issues with cy.task('queryDB')

avatar joomla-cms-bot joomla-cms-bot - change - 14 Jun 2023
Category Unit Tests Repository Administration com_admin SQL Postgresql com_banners com_categories com_config com_contact com_content com_contenthistory com_finder
avatar andyforrest andyforrest - open - 14 Jun 2023
avatar andyforrest andyforrest - change - 14 Jun 2023
Status New Pending
avatar richard67
richard67 - comment - 14 Jun 2023

@andyforrest Can it be that you have chosen the wrong base branch for this PR? GitHub shows a lot of differences. Maybe you anted to make this PR not for the 4.3-dev branch but for 4.4-dev or 5.0-dev? If that is the case you can switch the base branch by using the edit button beside the title of this pull request on GitHub. Let me know when you need help with that. Thanks in advance.

avatar richard67
richard67 - comment - 14 Jun 2023

@andyforrest I see you just fixed it, all good. Thanks.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Jun 2023
Category Unit Tests Repository Administration com_admin SQL Postgresql com_banners com_categories com_config com_contact com_content com_contenthistory com_finder JavaScript Unit Tests
avatar andyforrest andyforrest - change - 14 Jun 2023
Labels Added: ? PR-4.4-dev
avatar laoneo
laoneo - comment - 14 Jun 2023

Thanks, can you add the port argument also to the postgres connection, we are using this library https://github.com/porsager/postgres#connection.

avatar laoneo laoneo - close - 14 Jun 2023
avatar laoneo laoneo - merge - 14 Jun 2023
avatar laoneo laoneo - change - 14 Jun 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-14 14:18:11
Closed_By laoneo
avatar laoneo
laoneo - comment - 14 Jun 2023

Thanks, looking good!

Add a Comment

Login with GitHub to post a comment