[#40761] - Improve Calendar form field style - Issues #36933 & #33447
- Fixed in Code Base
- 8 Sep 2023
- Medium
- Build: 4.3-dev
- # 40761
- Diff
- cyrezdev:patch-54
User tests: Successful: Unsuccessful:
Pull Request for Issues #36933 & #33447.
Summary of Changes
Improve display of datetime picker.
- Centering calendar table for better looking in some not-english language.
- Style time select fields.
- Fix footer buttons alignment.
- Improve display of time fields depending on field settings (weeknumbers, am/pm).
Testing Instructions
- Apply patch, and test any form field of type calendar.
Actual result BEFORE applying this Pull Request
Example in French
Expected result AFTER applying this Pull Request
Example in French
Rendering depending on calendar field settings:
With or without weeknumbers, am/pm and or time. And with RTL support
Legend:
- Week numbers, time 24h
- Week numbers, time 12h
- Time 24h
- Time 12h
- No Time
- RTL (arabic)
(1) 
(2) 
(3) 
(4) 
(5) 
(6) 
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change JavaScript |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
I am confused. If I understand correctly then the problem only exists in non-english languages where the text for "today" is long. If that is correct then what is the purpose of all the screenshots you have posted in english
As mentionned in the description of this PR, it's not only for this point, but 3 other ones:
- To style time select fields.
- Fix footer buttons alignment.
- Improve display of time fields depending on field settings (weeknumbers, am/pm).
So the additionnal screenshots are valid to show the different possible settings for calendar form field.
It is mainly cosmetic here and to have a more flexible design ;-)
Looks good, fixes the main point of issue I highlighted.
| Title |
|
||||||
I have tested this item ✅ successfully on b668fc2
Tested with English and Persian
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40761.
| Labels |
Added:
PR-4.4-dev
Removed: PR-4.3-dev |
||
I have tested this item ✅ successfully on 145606e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40761.
Viviana @drmenzelit, can you put your results in the issue tracker once more? I am sorry, the branch update invalidated your results. Thanks!
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-08 16:29:50 |
| Closed_By | ⇒ | laoneo |
Thanks! Also for the fast tests...
I am confused. If I understand correctly then the problem only exists in non-english languages where the text for "today" is long.
If that is correct then what is the purpose of all the screenshots you have posted in english