[#40742] - [5.0] Added missing "items" text to the Joomla update view
- Fixed in Code Base
- 10 Jun 2023
- Medium
- Build: 5.0-dev
- # 40742
- Diff
- beni71:patch-3
User tests: Successful: Unsuccessful:
Pull Request for Issue #39829.
Summary of Changes
Added missing "items" text to the Joomla update view.
Testing Instructions
After the patch is applied you have to update your Joomla without reverting the code change of the patch!
Maybe there is an easier/better approach to do but you could follow these steps:
- Apply the patch
- Create a .zip file from your components folder and store that .zip file outside of the Joomla folder. It is used later to regularly update Joomla (which will just copy the same files).
- Login into the backend (administrator area).
- In the left hand toggle menu click "System".
- In the "Update" section click "Joomla".
- Click the button "Upload and Update".
- Choose your .zip file (from step 2).
- Check the box "I'm aware that a backup before any update is highly recommended. ".
- Click the button "Upload & Install".
- Confirm your credentials.
- Click button "Install".
Actual result BEFORE applying this Pull Request
In the third column only the number of extracted/processed items is visualized:
Expected result AFTER applying this Pull Request
In the third column the number of extracted/processed items is visualized with an additional text "items":
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Language & Strings JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.0-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40742.
Yet another critical note, with this pr:
5030 + 2622 = 7652 Files (= bestanden) + Folders (= mappen)
In other words, the suffix 'Files' is not correct. It be should be somethins like this: 'Files and folders' or 'Folders and files'.
Can this be confirmed?
[EDIT]
I have tested this item
See comment
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40742.
a folder is just a special kind of file,
Also plausible reasoning to consider files as a collective name of files and folders. It keeps the text short.
2 ways:
- Call it "Objects" or "Entries"
- Only show files as counter.
Using "Files" for Folders and Files maybe not completely wrong but I think we could use a more common wording.
2 ways:
- Call it "Objects" or "Entries"
- Only show files as counter.
- … or „Items“
- Good idea.
items
choose whatever
we are postponed the problem to the translators
One more suggestion. The Dutch word 'Inhoud' is English 'Content'.
Everyone knows what is meant by Content (and it is easy to translate
It's not content in English
And content is not countable.
When I unzip a .zip file in MS Windows, the progress dialog shows "items" (English) and, for example, "Elements" in German. I think we can reuse this phrase, some of you have already suggested it. And for other languages we would have a template.
When I unzip a .zip file in MS Windows, the progress dialog shows "items" (English) and, for example, "Elements" in German. I think we can reuse this phrase, some of you have already suggested it. And for other languages we would have a template.
so you have your answer please use items, then this can be merged.
thanks
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40742.
Image last test for information
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40742.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40742.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-10 14:46:23 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thanks
@beni71 There is not really the need to build your own package for testing. Our automated ci tool drone already does that for every pull request. When you use the „show all checks“ at the bottom of the pull request on GitHub, the ci checks are shown, among of them is a „Download“ step. Follow that link and you come to a page where you can find a custom update url and links to installation and update packages which contain the fix from this pull request.