[#40704] - Media manager should consider path variable
- Fixed in Code Base
- 26 Jun 2023
- Medium
- Build: 4.3-dev
- # 40704
- Diff
- Digital-Peak:media/path
User tests: Successful: Unsuccessful:
Pull Request for Issue #40690.
Summary of Changes
When passing a path variable in the browser url, the media manager should take that one to display the files instead of the one from the session.
Some system tests are also provided to make sure the combination between the session and url is playing nicely together.
This is a more lightweight alternative to the pr #40691.
Testing Instructions
- Go to /administrator/index.php?option=com_media&path=local-images:/sampledata
- Type in the url /administrator/index.php?option=com_media&path=local-images:/banners
Actual result BEFORE applying this Pull Request
The media manager redirects to the sampledata directory.
Expected result AFTER applying this Pull Request
The media manager shows the contents of the banners directory.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change Unit Tests |
| Status | New | ⇒ | Pending |
It is the same behavior as now, currently you you just have to set the invalid folder in the session.
But the session is only set by the app?
And when you put an invalid path in the url, then an error message is shown:
This pr restores the old behavior we had in 4.3.0. Changing the path to a valid one when it is invalid is not the scope of this pr and should probably be done in 5.0.
But the session is only set by the app?
Yes, but it doesn't mean it can't be invalid. When one user browses to a folder and then another one deletes that folder, you get the same result as with this pr when you put an invalid folder name into the url.
This pr restores the old behavior we had in 4.3.0.
This behaviour was, and after this PR is still, broken. The state of the app is not set correctly (ie there is no initial selected folder and there is no code to cope with that), in short the media manager initial state could be really harmful
At least you can pass again the path by url which is now not possible.
Ok, have it your way
if a non existing path now results in a success then this is not correct
if you can then write to that then its a security issue
| Labels |
Added:
?
NPM Resource Changed
bug
PR-4.3-dev
|
||
| Category | JavaScript Administration com_media NPM Change Unit Tests | ⇒ | JavaScript Administration com_media NPM Change Repository Unit Tests |
I have tested this item
The path on the URL is respected but there are quite a few inconsistencies and things should be done differently when media manager is booting. Also The store needs to be migrated to pinia. Allon is aware of this but for 4.3 this is fixing the regression
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40704.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40704.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40704.
| Labels |
Added:
?
|
||
obuisard
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-26 13:11:33 |
| Closed_By | ⇒ | obuisard |
Allen this enables a faulty behavior:
/administrator/index.php?option=com_media&path=local-images:/notexistingyou get: