[#40699] - [4.3] change icon for failed checks
- Closed
- 8 Sep 2023
- Medium
- Build: 4.3-dev
- # 40699
- Diff
- brianteeman:patch-6
User tests: Successful: Unsuccessful:
On the system cpanel there is a json check for various things such as available updates. This will normally show either a ✔️ or a count. BUT in some circumstances the check fails and in this case a ❌ is displayed.
Summary of Changes
As we normally use the ❌to indicate that something can be removed or deleted this is confusing andb doesnt indicate that there was any problem in getting the data. This PR changes the icon to ❓
Testing Instructions
This is a js change so you will need to either code review, use a pre-built install or run npm run build:js
The harder part is to force the json error so that the icon is displayed. If you are on a localhost then you might try to disable the internet and then go to the system cpanel.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
i deliberately didn't want something as strong as that
@brianteeman Not sure if I like the question mark for the reason stated by @wwwiiimmm . But I agree with you about the proposal. How about a red exclamation mark instead of a red question mark, but with the same styling, no triangle or so?
A question mark is not appropriate here, because a question mark suggests that an update must be performed. But it doesn't have to be that way. A question mark breeds doubt.
A question mark breeds doubt.
it should do - thats the point
About testing instruction: Set debug-mode "on" and error-reporting "maximum" - this displays the "x"
what about just only as an informational icon ?
something like
What about the flash icon?
The one that makes sense to me is the exclamation mark without the triangle (f12a or fas fa-exclamation).
Agree with this PR that the X needs to changed with something else. I am ok with the red ?, even though we use it for help, but the red color adds context (but not to the color blind).
I am happy with the ? icon I selected. If maintainers want to reject this PR and replace it with a different pr with a different icon then that is their choice.,
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-08 11:53:15 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
NPM Resource Changed
bug
PR-4.3-dev
|
||
I believe people may think a question mark for hints or help. Joomla uses a question mark for the Help button.
May I suggest using an exclamation mark, maybe inside a (triangle) badge.
See attachment...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40699.