Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40682] - [5.0] Refactor the tinyMCE highlight plugin (code+)

Feature NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
29 May 2023

Pull Request for Issue # .

Summary of Changes

  • Drop the source.html file
  • Introduce a com_ajax endpoint for the above html (this is also reintroducing #40649)
  • move the options to the PHP side (still not exposed in the builder UI)

Testing Instructions

after npm ci check that the view source is working as expected

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@HLeithner I didn't added the UI elements for the options, should be an easy task

avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2023
Category ⇒ JavaScript Repository NPM Change Front End com_ajax Plugins
avatar dgrammatiko dgrammatiko - open - 29 May 2023
avatar dgrammatiko dgrammatiko - change - 29 May 2023
Status New ⇒ Pending
avatar dgrammatiko dgrammatiko - change - 29 May 2023
Labels Added: NPM Resource Changed PR-5.0-dev
d0c30e8 29 May 2023 avatar dgrammatiko cs
72ae9d0 29 May 2023 avatar dgrammatiko meh
avatar richard67
richard67 - comment - 29 May 2023

@dgrammatiko Could you add

'/media/plg_editors_tinymce/js/plugins/highlighter/source.html',

before this line here? https://github.com/joomla/joomla-cms/blob/5.0-dev/administrator/components/com_admin/script.php#L617

Thanks in advance.

avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2023
Category JavaScript Repository NPM Change Front End com_ajax Plugins ⇒ Administration com_admin JavaScript Repository NPM Change Front End com_ajax Plugins
avatar dgrammatiko
dgrammatiko - comment - 29 May 2023

@richard67 done

avatar HLeithner
HLeithner - comment - 30 May 2023

@brianteeman do you have time to test this please?

avatar brianteeman
brianteeman - comment - 30 May 2023

@HLeithner its on my todo list for today

avatar brianteeman brianteeman - test_item - 30 May 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 May 2023

I have tested this item ✅ successfully on e0a23b4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40682.

avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2023
Category JavaScript Repository NPM Change Front End com_ajax Plugins Administration com_admin ⇒ Administration com_admin JavaScript Repository NPM Change Front End Plugins
ab37e89 30 May 2023 avatar dgrammatiko CS
avatar dgrammatiko dgrammatiko - change - 30 May 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 30 May 2023
44b1d42 31 May 2023 avatar dgrammatiko CSP
avatar HLeithner
HLeithner - comment - 26 Jun 2023

I'm not merging this for alpha2 but how is the status of codemirror upgrade since we have esm native support now? is it now easier possible?

avatar Fedik
Fedik - comment - 26 Jun 2023

how is the status of codemirror upgrade

Work in progress

avatar dgrammatiko
dgrammatiko - comment - 26 Jun 2023

@HLeithner FWIW this PR is a better base for CM6 which @Fedik is working on (there's a basic implementation here but it needs both the importmaps and this PR IMO)

avatar dgrammatiko dgrammatiko - change - 26 Jun 2023
Labels Added: Feature
avatar dgrammatiko dgrammatiko - close - 23 Aug 2023
avatar dgrammatiko dgrammatiko - change - 23 Aug 2023
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-08-23 15:27:56
Closed_By ⇒ dgrammatiko

Add a Comment

Login with GitHub to post a comment