[#40626] - [5.0] tinyMCE b/c fixes
- Fixed in Code Base
- 29 May 2023
- Medium
- Build: 5.0-dev
- # 40626
- Diff
- dgrammatiko:5.0-dev-tiny-fixes
User tests: Successful: Unsuccessful:
Pull Request for Issue #40622
Summary of Changes
- @richard67 added a function to transform some J3/4 parameters to their new expected values for tinyMCE v6
- Replaced the same values in the installation SQL files
- Removed the template plugin as it's deprecated
- Introduce a fork of the template plugin, named
jtemplate - Patch both the builder for the above change
- Introduce a function
onAjaxTinymce(), so that templates will be fetched on request rather than on the rendering of the editor (security + perf) - Removed/renamed plugins and options to satisfy the changes of tinyMCE v6
Testing Instructions
-
d/l and install a fresh copy of Joomla from the GH PR. Check that tinyMCE works as expected, particularly check the templates functionality.
-
Have a J4 installation and create some more
TinyMCE Sets. Try to use all the buttons,menus,etc, and also have some html (or txt) files as templates in thecassiopeia/html/tinymce. UPGRADE to J5 using theCustom URLin theadministrator/index.php?option=com_config&view=component&component=com_joomlaupdate&path=with a vaulehttps://ci.joomla.org/artifacts/joomla/joomla-cms/5.0-dev/40626/downloads/65966/pr_list.xml. Enure that the configuarations are identical and that the templates are still working.
Actual result BEFORE applying this Pull Request
Broken Upgrade
Expected result AFTER applying this Pull Request
No breaks
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
forced_root_block must be a non-empty string and cannot take a value of false.
So what should it be?
no idea
textpattern options https://www.tiny.cloud/docs/tinymce/6/6.0-release-notes-core-changes/#removed-or-deprecated-options-textpattern
memo to self to review this
'paste' => ['label' => 'Paste', 'plugin' => 'paste'],
'pastetext' => ['label' => 'Paste as text', 'plugin' => 'paste'],
https://www.tiny.cloud/docs/tinymce/6/6.0-release-notes-core-changes/#changed-plugins-paste
'emoticons' => ['label' => 'Emoticons', 'plugin' => 'emoticons'],
Check but i think that means the label is now "Emoji"
emoticons
This still exists in the plugin folder
@brianteeman you can ignore this as the name is correct:
To Check
- Do we still need any of the language strings PLG_TINY_TOOLBAR_BUTTON_ etc
- Button Seperator not displayed
- Editor has rounded corners
- Emoji/Emoticons
- Text patterns
- Forced root block -
think this was something @crystalenka added
| Category | Front End Plugins | ⇒ | SQL Installation Front End Plugins |
| Category | Front End Plugins SQL Installation | ⇒ | SQL Installation Postgresql Front End Plugins |
Button Seperator not displayed
That's a visual difference for v6 (there's no separation bar anymore)
| Category | Front End Plugins SQL Installation Postgresql | ⇒ | JavaScript Repository NPM Change SQL Installation Postgresql Front End Plugins |
| Labels |
Added:
NPM Resource Changed
|
||
shouldnt jtemplate live in here \build\media_source\plg_editors_tinymce\js\plugins
shouldnt jtemplate live in here \build\media_source\plg_editors_tinymce\js\plugins
This would require more changes in the builder
But it would be the correct way forward and then wont require further changes when they actually remove it?
| Category | Front End Plugins SQL Installation Postgresql JavaScript Repository NPM Change | ⇒ | JavaScript Repository NPM Change SQL Installation Postgresql Layout Front End Plugins |
But it would be the correct way forward and then wont require further changes when they actually remove it?
Ok, the code was moved to the correct folder
| Category | Front End Plugins SQL Installation Postgresql JavaScript Repository NPM Change Layout | ⇒ | Administration com_admin JavaScript Repository NPM Change SQL Installation Postgresql Layout Front End Plugins |
@dgrammatiko I've allowed myself to update your branch for this PR to the latest 5.0-dev with the results of the upmerge so that we get a usable update package built by Drone for this PR, and so people can use that for testing the migration. Before that, updating from 4.4 to 5 was broken due to the missing upmerge.
I will update the description, testing instructions, etc, later on or tomorrow
Button Seperator not displayed
That's a visual difference for v6 (there's no separation bar anymore)
The problem then is that the visual seperator is still shown in the plugin configuration
| Labels |
Added:
bug
|
||
Can you please update the licence in the tinymce.xml as it is no longer LGPL but is instead MIT
source code plugin (highlighter) fails with
```
plugin-es5.min.js:1 Uncaught TypeError: Cannot read properties of undefined (reading 'codemirror')
at Object.t [as onAction] (plugin-es5.min.js:1:153)
at theme.min.js:4:283552
at theme.min.js:4:123218
at theme.min.js:4:283521
at theme.min.js:4:30451
at L (theme.min.js:4:2411)
at run (theme.min.js:4:30436)
at theme.min.js:4:31303
at theme.min.js:4:795
at theme.min.js:4:152163
source code plugin (highlighter) fails with
I've seen it as well, but let's leave this for another PR (it needs also the Codemirror v5 upgrade). I mean patching the plugin for the existing code mirror would be wasted energy as the editor needs an upgrade...
| Labels |
Added:
Release Blocker
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-29 07:09:02 |
| Closed_By | ⇒ | HLeithner |
thanks, can you please create a pr for the issue mentioned by brian?
\plugins\editors\tinymce\src\PluginTraits\DisplayTrait.php
$scriptOptions['forced_root_block'] = '';