[#40576] - Feature/40545 remove inline padding on highlight search words
- Fixed in Code Base
- 12 May 2023
- Medium
- Build: 4.3-dev
- # 40576
- Diff
- hans2103:feature/40545
User tests: Successful: Unsuccessful:
Pull Request for Issue #40545
Summary of Changes
The issue was caused by merging code changes on highlight.js in PR #38908 solving
This PR will revert those changes and solve the initial issue #38903
Issue solved by reset inline padding on the search words by overriding Bootstrap variable $mark-padding
Testing Instructions
Follow testing instruction as described by both issues #40545 and #38903
After applying the patch the command npm run build should be executed to regenerate both js and css files.
Actual result BEFORE applying this Pull Request
- Search word
Administratorwill not be highlighted when it is followed by a dot or comma. - Search word
Foo Bar FooBarwill be highligted
Expected result AFTER applying this Pull Request
- Search word
Administratorwill be highligted - Search word
Foo Bar FooBarwill be highligted
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End Templates (site) |
| Status | New | ⇒ | Pending |
| Category | JavaScript Repository NPM Change Front End Templates (site) | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
@hans2103 It looks as if this PR also contains the changes from your other PR #40574 .
@richard67 oh boy... solved by reverting those changes
@hans2103 It looks as if this PR also contains the changes from your other PR #40574 .
@richard67 oh boy... solved by reverting those changes
Yep, looks ok now.
@iqrafarah Could you test again? Thanks in advance.
I have tested this item
I have tested it again and it works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40576.
I have tested this item
Tested this and it seems to work. Tested this on google chrome
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40576.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40576.
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-12 21:55:27 |
| Closed_By | ⇒ | obuisard |
I have tested this item✅ successfully on 2fdb994
I have tested this and everything seems to work.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40576.