[#40563] - End of support plugin 4.4 (based on previous PR #40556)
- Closed
- 9 May 2023
- Medium
- Build: 4.3-dev
- # 40563
- Diff
- mfleeson:End-Of-Support-Plugin-4.4
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Originally this code was monitored and checked in #40556
I messed up my local installation and then managed to close the original PR when I renamed the branch. Mea Culpa. My apologies.
Summary of Changes
Rewriting the 3.10 End of Service Notification and placing it into Joomla 4 coding structure and style.
Simplified the language definitions to not be hardcoded for 3 to 4
Currently using const EOS_DATE = '2023-10-25'; in file plugins/quickicon/eos/src/Extension/Eos.php The correct date should be 2025-10-25 but then the notification does not appear.
Dimitris converted the jQuery code into working javascript for closing the notification and also calling the com_ajax so the hide me is stored in the plugin parameters.
Testing Instructions
Build.
Check plg_quickicon_eos is enabled.
View Home Dashboard in the back end.
Actual result BEFORE applying this Pull Request
No notification is displayed
Expected result AFTER applying this Pull Request
A notification is displayed
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql com_banners com_categories com_config com_contact com_content com_contenthistory com_finder |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-09 16:46:57 |
| Closed_By | ⇒ | mfleeson | |
| Labels |
Added:
?
PR-4.3-dev
|
||
Shouldn't this go against the 4.4-dev branch anyway?
I thought that was what i did? Its the reason I stopped the previous cos
windows git linked it against 4.3.
Mark
On Tue, 9 May 2023 at 21:53, Hannes Papenberg @.***>
wrote:
Shouldn't this go against the 4.4-dev branch anyway?
—
Reply to this email directly, view it on GitHub
#40563 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHKY5WBXOADCKOYCURPMXTXFKVFTANCNFSM6AAAAAAX3R5QGQ
.
You are receiving this because you were assigned.Message ID:
@.***>
You can change the branch which it points at via the GUI here. Just click on edit next to the title and select the right branch.
Sorry, although my fork was from 4.4, this tried to apply the 4.4 changes onto 4.3. Will try again!