@laoneo PHPCS fails due to method names with underscores. It either needs to fix that in the file itself, or you add the file to this rule at the right place: https://github.com/joomla/joomla-cms/blob/4.4-dev/ruleset.xml#L150

Update: Details from drone

FILE: /drone/src/plugins/content/pagebreak/src/Extension/PageBreak.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 264 | ERROR | Method name "_createToc" must not be prefixed with an underscore to indicate visibility
 336 | ERROR | Method name "_createNavigation" must not be prefixed with an underscore to indicate visibility
----------------------------------------------------------------------

@sandewt do you have time to test this one?

@sandewt do you have time to test this one?

I'll make some time. Testing is phased.

Vote plugin: tested successfully (1)

• works + code review

Load Modules plugin: tested successfully (2)

• works + code review

Finder plugin: tested successfully (3)

• works + code review

Rest follows...

[EDIT]

I have tested this item ✅ successfully on f391d2f

@MacJoom Hmm, not really helpful to do a branch update without restoring @heelc29 's test result in the issue tracker using the "Alter test" button. A branch update always resets the human tests counter, and so we won't find this PR later after another human test when we are searching for PR's which have 2 tests for setting them RTC. I have restored the test in the issue tracker now, but you can't always count on me being around.

It's great that this PR has been merged, but I can't keep up with the pace of testing. See above. ?

No problem, target was to ship it with the first alpha. Hopefully we get then a bigger audience which will check it.