[#40524] - Upgrade font awesome to version 6
- Fixed in Code Base
- 29 May 2023
- Medium
- Build: 5.0-dev
- # 40524
- Diff
- Digital-Peak:fontawesome6
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Upgrades font awesome to version 6.
Testing Instructions
Browse around in Joomla.
Actual result BEFORE applying this Pull Request
All icons are displayed.
Expected result AFTER applying this Pull Request
All icons are displayed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
@laoneo this won’t cut it, as you break everything from j4 that are referencing fa5. Get the code from here: https://github.com/joomla/joomla-cms/pull/36906/files
Can you not open then a new pr with the upgrade? I don't want to copy your code and you understand it more deeply than me.
| Labels |
Added:
Feature
NPM Resource Changed
PR-5.0-dev
|
||
| Category | JavaScript Repository NPM Change | ⇒ | JavaScript Repository NPM Change Installation |
@dgrammatiko can you have a look again as I did copy the fontawesome related changes from #36906?
LGTM
can you create a documentation entry on manual joomla for this because it's a b/c break for some images (iirc some images are missing in 6)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-29 07:32:48 |
| Closed_By | ⇒ | HLeithner |
I think that's not a sufficient test. It would also need to check if running "npm ci" (or "npm run build:js" and "npm run build:css") show any new errors or warnings.