[#40501] - [4] PHP 8.1 - FTP Extension
- Closed
- 4 Jul 2023
- Medium
- Build: 4.3-dev
- # 40501
- Diff
- alikon:patch-4
User tests: Successful: Unsuccessful:
Pull Request for Issue #40438.
Summary of Changes
Existing code that relied on is_resource function now needs to account for the new FTP\Connection class objects in PHP 8.1.
Testing Instructions
see #40438.
Actual result BEFORE applying this Pull Request
fail
Expected result AFTER applying this Pull Request
works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
As stated in the issue report it is being used.
FTP is still being used by most of europes real estate business.
When trying this fix under PHP 8.1 i get
0 ftp_login(): Argument #1 ($ftp) must be of type FTP\Connection, null given
here:
joomla-cms/libraries/src/Client/FtpClient.php
Line 364 in 9121903
Same setup as PHP 8.0 without the issue
feel free to do a pr yourself @stell or send a pr to this branch https://github.com/alikon/joomla-cms/tree/patch-4
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-04 15:14:52 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
PHP 8.x
bug
PR-4.3-dev
|
||
Can't we just remove it?...