? ? Language Change PR-5.0-dev ? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
28 Apr 2023

Pull Request for Issue # .

Summary of Changes

This PR sets the group select field in user mass mail screen befor the checkbox for recursion.
Why?
Selection recursion before knowing the group tree "makes me think".

Testing Instructions

Check the user mass mail view before and after patch.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2023
Category Administration com_users
avatar chmst chmst - open - 28 Apr 2023
avatar chmst chmst - change - 28 Apr 2023
Status New Pending
avatar brianteeman
brianteeman - comment - 28 Apr 2023

I agree with the changed ordering but I wonder if it would be easier to understand the purpose of those fields if they also had a heading

avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2023
Category Administration com_users Administration com_users Language & Strings
avatar chmst chmst - change - 28 Apr 2023
Labels Added: ? ? ? PR-4.4-dev
avatar chmst
chmst - comment - 28 Apr 2023

I agree with the changed ordering but I wonder if it would be easier to understand the purpose of those fields if they also had a heading

I could not find a good heading. Maybe we could simply change the label?

avatar chmst chmst - change - 28 Apr 2023
Title
Swap fields for mass mail
[4.4] Swap fields for mass mail
avatar chmst chmst - edited - 28 Apr 2023
avatar brianteeman
brianteeman - comment - 28 Apr 2023

group
==>
Recipient Group

avatar chmst chmst - change - 28 Apr 2023
Labels Added: Language Change
avatar sandewt
sandewt - comment - 28 Apr 2023

No documentation changes for docs.joomla.org needed

New screenshot is needed, see link https://docs.joomla.org/Help310:Users_Mass_Mail_Users

avatar brianteeman
brianteeman - comment - 28 Apr 2023

I assume that you actually meant this url which is for Joomla 4
https://docs.joomla.org/Help4.x:Mass_Mail_Users

avatar sandewt
sandewt - comment - 28 Apr 2023

I assume that you actually meant this url which is for Joomla 4

Oops, correct.

avatar sandewt sandewt - test_item - 28 Apr 2023 - Tested successfully
avatar sandewt
sandewt - comment - 28 Apr 2023

I have tested this item successfully on d54346e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40500.

avatar viocassel viocassel - test_item - 28 Apr 2023 - Tested successfully
avatar viocassel
viocassel - comment - 28 Apr 2023

I have tested this item successfully on d54346e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40500.

avatar alikon alikon - change - 28 Apr 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 28 Apr 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40500.

avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2023
Category Administration com_users Language & Strings Repository Administration com_admin com_categories com_finder com_modules com_users Language & Strings Front End com_contact com_tags Installation
avatar chmst chmst - change - 28 Apr 2023
Title
[4.4] Swap fields for mass mail
[5.0] Swap fields for mass mail
avatar chmst chmst - edited - 28 Apr 2023
avatar bembelimen bembelimen - change - 29 Apr 2023
Labels Added: ? PR-5.0-dev
Removed: PR-4.4-dev
avatar brianteeman
brianteeman - comment - 29 Apr 2023

Not sure why this has been bumped to 5.0 but the rebase hasnt worked

avatar chmst
chmst - comment - 29 Apr 2023

4.4 should not have new features. I close here and open a fresh PR for 5.0

avatar chmst chmst - close - 29 Apr 2023
avatar chmst chmst - change - 29 Apr 2023
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2023-04-29 21:40:09
Closed_By chmst
avatar brianteeman
brianteeman - comment - 29 Apr 2023

4.4 should not have new features. I close here and open a fresh PR for 5.0

I fail to see how changing the order of two fields is a new feature.

Add a Comment

Login with GitHub to post a comment