Feeling Lucky
?
bug
PR-4.3-dev
[#40496] - [4.3] Com_banners string [a11y]
- Fixed in Code Base
- 6 May 2023
- Medium
- Build: 4.3-dev
- # 40496
- Diff
- brianteeman:patch-15
User tests: Successful: Unsuccessful:
Summary of Changes
The language key used to provide the aria label on the banner edit form is incorrect. This PR corrects that
Testing Instructions
in the admin view the source of the banner edit form and the client edit form
Note that if it is a new banner or an edit banner the string is slightly different
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
alikon
- comment
- 27 Apr 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40496.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 27 Apr 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40496.
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-06 01:13:57 |
| Closed_By | ⇒ | obuisard |
obuisard
- comment
- 6 May 2023
Thank you Brian @brianteeman :-)
brianteeman
- comment
- 6 May 2023
thanks
I have tested this item✅ successfully on 97c5f70
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40496.