[#40462] - [5.0] Generic ModalSelect field
- Fixed in Code Base
- 2 Sep 2023
- Medium
- Build: 5.0-dev
- # 40462
- Diff
- Fedik:popup-field3
User tests: Successful: Unsuccessful:
Summary of Changes
Adding new generic ModalSelectField to select content in modal.
This is addittion to #40150 to improve our modal windows.
And should replace (in future) modal-fields.js.
Instead of hardcoded callback, now it should be used window.postMessage() wich is more safe, and all Form buttons should be within same DOM document.
This approcah also will help to improve Editor-xtd buttons #40202.
In this PR I have transfrmed Modal_Article field to use new ModalSelect.
However it still will be need some work to improve handling propagationAssotiation.
Testing Instructions
Apply #40150 patch and apply current PR.
Go to menu and crate a Single Article menu.
In article field test: Select, Create, Clear buttons.
In multilanguage site try edit Article association.
Also can test the field in subform:
<field type="subform" name="subform" label="subform" multiple="true">
<form>
<field
type="ModalSelect"
name="article" label="Article"
urlSelect="index.php?option=com_content&view=articles&layout=modal&tmpl=component"
/>
</form>
</field>Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works but better :)
Link to documentations
Please select:
- Documentation link for docs.joomla.org: https://docs.joomla.org/Standard_form_field_types
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: joomla/Manual#178
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_contact com_content com_menus Templates (admin) JavaScript Repository NPM Change Layout Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
NPM Resource Changed
PR-5.0-dev
|
||
| Title |
|
||||||
a more generic for example to have one "modalreturn" layout
This mainly need to handle "Save & Close" / "Cancel" (in modal) because after save we always have a redirect.
I thinking about generic layout, kind of what we have for "emptystate". Will see, maybe later will find some better ideas.
Really excited about this
Really excited about this
me too
me too!
@brianteeman do you remember what Propagation button actualy doing (in multilanguage)?
Currently it is coded in to every Article_Modal, Menu_Modal etc. fields. It a bit hacky thing that I have no idea what to do :)
I have zero idea. Everytime I tried to work it out I failed
| Labels |
Added:
Feature
Removed: ? |
||
| Labels |
Added:
Documentation Required
|
||
I like it, it looks good. only thing I'm not so sure if the buttons in the iframe are a good idea... we don't have much space in the iframe and that's another row...
looking at the Ipad air there is not much room for real content
we don't have much space in the iframe and that's another row...
They will eat space wherever you place them, but they should be within the same document where the form is.
there is not much room for real content
I would not expect much room for such editing anyway.
Default dialog size is:
width: 80vw;
max-width: 1700px;
height: 80vh;
And can be styled.
I have increased default size
I have prepared changes for Menu field also: Fedik/joomla-cms@5.0-dev...popup-field-menu
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-02 16:06:37 |
| Closed_By | ⇒ | HLeithner |
thanks, I merge this for beta1 to get better feedback and we have time to fix issues.
I like the postMessage approach. I'm not sure if it could be a more generic for example to have one "modalreturn" layout for all usages of the modalfield.