NPM Resource Changed PBF bug Small PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

Summary of Changes

Updated the onChange handler for the 'Menu' field to pass all options for the 'Parent Item' field to the setChoices function of the Choices instance created by JoomlaFieldFancySelect using a single call, rather than one call per option.

Testing Instructions

This issue was experienced when a menu containing 1814 published menu items was selected.

  • Create a new menu item, or edit an existing one.
  • Using the 'Menu' field, select a menu containing a large number of menu items.
    • The issue does not occur if the menu containing a large number of menu items is already selected.

Environmental Information

Joomla 4.3.0
PHP 8.0.26
Google Chrome 112.0.5615,138

Actual result BEFORE applying this Pull Request

The browser becomes temporarily unresponsive after selecting a menu containing a large number of items using the 'Menu' field. Continuing to edit the menu item is not possible until the processing of options for the 'Parent Item' field is complete.

Expected result AFTER applying this Pull Request

Selecting a menu containing a large number of menu items using the 'Menu' field does not effect browser responsiveness. Editing the menu item can continue as normal.

Link to documentations

No documentation changes for docs.joomla.org needed.
No documentation changes for manual.joomla.org needed.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2023
Category JavaScript Repository NPM Change
avatar mattelkins-bluefrontier mattelkins-bluefrontier - open - 22 Apr 2023
avatar mattelkins-bluefrontier mattelkins-bluefrontier - change - 22 Apr 2023
Status New Pending
avatar mattelkins-bluefrontier mattelkins-bluefrontier - change - 23 Apr 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar mattelkins-bluefrontier mattelkins-bluefrontier - change - 25 Apr 2023
Title
Browser becomes temporarily unresponsive when editing a menu item and selecting a menu containing a large number of items
[4.3] Browser becomes temporarily unresponsive when editing a menu item and selecting a menu containing a large number of items
avatar mattelkins-bluefrontier mattelkins-bluefrontier - edited - 25 Apr 2023
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[4.3] Browser becomes temporarily unresponsive when editing a menu item and selecting a menu containing a large number of items
[4.4] Browser becomes temporarily unresponsive when editing a menu item and selecting a menu containing a large number of items
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar mattelkins-bluefrontier mattelkins-bluefrontier - change - 7 Jun 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-06-07 17:48:51
Closed_By mattelkins-bluefrontier
Labels Added: PBF bug Small PR-4.4-dev
Removed: PR-4.3-dev
avatar mattelkins-bluefrontier mattelkins-bluefrontier - close - 7 Jun 2024

Add a Comment

Login with GitHub to post a comment