Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4042] - Change message type to 'error' when delete fail JControllerAdmin (legacy)

? Success

User tests: Successful: Unsuccessful:

avatar xpallicer
xpallicer
31 Jul 2014

Change message type to 'error', instead of default 'message' when delete fails

avatar xpallicer xpallicer - open - 31 Jul 2014
avatar xpallicer xpallicer - change - 31 Jul 2014
Labels Added: ? ?
avatar brianteeman brianteeman - change - 8 Aug 2014
Labels Added: ?
Removed: ?
avatar n9iels
n9iels - comment - 9 Aug 2014

@test: Looks fine! (I don't know if I can test this PR in some way?)

avatar zero-24
zero-24 - comment - 9 Aug 2014

@n9iels

(I don't know if I can test this PR in some way?)

Sure :-D

  1. change https://github.com/xpallicer/joomla-cms/blob/patch-1/libraries/legacy/controller/admin.php#L130 to
if (!$model->delete($cid))
  1. create (green) --> trash (green) --> delete (green) a article.
  2. apply the change (add the code manually is easier)
  3. create (green) --> trash (green) --> delete (red) a article.
  4. undo the change from 1.

PS: The last message ist empty as there is no error. :-D

@test successful --> RTC

avatar n9iels
n9iels - comment - 9 Aug 2014

@test successful
@zero-24: Thanks :-)

avatar Bakual Bakual - change - 9 Aug 2014
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-08-09 10:08:15
avatar Bakual Bakual - close - 9 Aug 2014

Add a Comment

Login with GitHub to post a comment