? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
31 Jul 2014

See #3955 (comment)
Test with

<p><a href="mailto:info@mysite.com"><img style="margin: 0px 3px 0px 0px; float:left; width:21px; height:21px;" title="Email to me" src="images/powered_by.png" alt="An email" width="21" height="21" /> Contact us</a><p>

and

<p><a href="mailto:info@mysite.com?subject=A Text"><img style="margin: 0px 3px 0px 0px; float:left; width:21px; height:21px;" title="Email to me" src="images/powered_by.png" alt="An email" width="21" height="21" /> Contact us</a><p>

Will have to be added also to:
#3967

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=34020&start=0

avatar infograf768 infograf768 - open - 31 Jul 2014
avatar infograf768 infograf768 - change - 31 Jul 2014
Labels Added: ? ?
avatar infograf768 infograf768 - change - 31 Jul 2014
The description was changed
Description <p>See <a href="https://github.com/joomla/joomla-cms/pull/3955#issuecomment-50634158" class="issue-link" title="[2.5] Change the cloak container from div to span">#3955 (comment)</a><br> Test with</p> <pre><code>&lt;p&gt;&lt;a href="mailto:info@mysite.com"&gt;&lt;img style="margin: 0px 3px 0px 0px; float:left; width:21px; height:21px;" title="Email to me" src="images/powered_by.png" alt="An email" width="21" height="21" /&gt; Contact us&lt;/a&gt;&lt;p&gt; </code></pre> <p>and</p> <pre><code>&lt;p&gt;&lt;a href="mailto:info@mysite.com?subject=A Text"&gt;&lt;img style="margin: 0px 3px 0px 0px; float:left; width:21px; height:21px;" title="Email to me" src="images/powered_by.png" alt="An email" width="21" height="21" /&gt; Contact us&lt;/a&gt;&lt;p&gt; </code></pre> <p>Will have to be added also to:<br><a href="https://github.com/joomla/joomla-cms/pull/3967" class="issue-link" title="Fixing bugs for emailcloak plugin">#3967</a></p> <p>See <a href="https://github.com/joomla/joomla-cms/pull/3955#issuecomment-50634158" class="issue-link" title="[2.5] Change the cloak container from div to span">#3955 (comment)</a><br> Test with</p> <pre><code>&lt;p&gt;&lt;a href="mailto:info@mysite.com"&gt;&lt;img style="margin: 0px 3px 0px 0px; float:left; width:21px; height:21px;" title="Email to me" src="images/powered_by.png" alt="An email" width="21" height="21" /&gt; Contact us&lt;/a&gt;&lt;p&gt; </code></pre> <p>and</p> <pre><code>&lt;p&gt;&lt;a href="mailto:info@mysite.com?subject=A Text"&gt;&lt;img style="margin: 0px 3px 0px 0px; float:left; width:21px; height:21px;" title="Email to me" src="images/powered_by.png" alt="An email" width="21" height="21" /&gt; Contact us&lt;/a&gt;&lt;p&gt; </code></pre> <p>Will have to be added also to:<br><a href="https://github.com/joomla/joomla-cms/pull/3967" class="issue-link" title="Fixing bugs for emailcloak plugin">#3967</a></p> <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&amp;tracker_item_id=34020&amp;start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&amp;tracker_item_id=34020&amp;start=0</a></p>
Labels Added: ?
Removed: ?
avatar infograf768 infograf768 - change - 1 Aug 2014
Title
Allowing cloaking when image and text
[#34020] Allowing cloaking when image and text
avatar infograf768
infograf768 - comment - 1 Aug 2014

Added 2 cases:

/*
         * Search for derivatives of link code <a href="mailto:email@example.org">
         * <img anything>email@example.org</a>
         */

and

/*
         * Search for derivatives of link code
         * <a href="mailto:email@amail.com?subject=Text"><img anything>email@amail.com</a>
         */

Test with

<p><a href="mailto:info@mysite.com"><img style="margin: 0px 3px 0px 0px; float:left; width:21px; height:21px;" title="Email to me" src="images/powered_by.png" alt="An email" width="21" height="21" />info@mysite.com</a><p>

and

<p><a href="mailto:info@mysite.com?subject= A subject"><img style="margin: 0px 3px 0px 0px; float:left; width:21px; height:21px;" title="Email to me" src="images/powered_by.png" alt="An email" width="21" height="21" />info@mysite.com</a><p>
avatar infograf768
infograf768 - comment - 2 Aug 2014

You can't test this on 2.5.
As it works fine on 3.3.3 (See tracker http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=34020&start=0)
I merge.

Will test a modified #3967 on a 2.5

avatar infograf768 infograf768 - change - 2 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-02 06:54:24
avatar infograf768 infograf768 - close - 2 Aug 2014
avatar infograf768
infograf768 - comment - 2 Aug 2014

Test by replacing emailcloak.php in a 2.5.24 by this file:
http://info-graf.fr/ftpfolder/emailcloak.php.zip

avatar infograf768
infograf768 - comment - 2 Aug 2014

What was, again, the original code used?
I tested with the codes I quoted here:
#4041 (comment)

and all is fine.
screen shot 2014-08-02 at 17 56 34

avatar RedEvo
RedEvo - comment - 2 Aug 2014

This is the HTML that renders with cloaking turned off.

<span class="contact email"><a href="mailto:info@redevolution.com"><img style="margin: 0px 5px 0px 0px; float: left; width: 27px; height: 27px;" title="Email Red Evolution" src="/images/stories/icons/social_icons/icon_email.png" alt="Email Red Evolution" width="27" height="27" /> info@redevolution.com</a></span>

thanks

d

avatar infograf768
infograf768 - comment - 2 Aug 2014

Take off the space before the mail here:

height="27" /> info@redevolution.com</a>

and test with

height="27" />info@redevolution.com</a>
avatar RedEvo
RedEvo - comment - 4 Aug 2014

Solved. Many thanks.

avatar infograf768
infograf768 - comment - 4 Aug 2014

I posted a new zip for 2.5.x (same url as above http://info-graf.fr/ftpfolder/emailcloak.php.zip ) which also adds these cases:
#4069 // that one is for 3.3.x
Thanks for testing on both

avatar zero-24
zero-24 - comment - 4 Aug 2014

Add a Comment

Login with GitHub to post a comment