[#40418] - [5.0] Drop tinyMCE own languages
- Closed
- 6 May 2023
- Medium
- Build: 5.0-dev
- # 40418
- Diff
- dgrammatiko:drop-langs
User tests: Successful: Unsuccessful:
Pull Request for Issue #40408 .
Summary of Changes
Use the official translation files
Testing Instructions
Run npm ci and check that changing the language in tinyMCE still works as before
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
A note here: this could be alternative done as a GitHub action similar to the Joomla languages with the benefit that there will not be an additional nom dependency for the adm-zip module and also keep the tools execution time shorter...
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Language & Strings NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.0-dev
|
||
| Category | JavaScript Repository Language & Strings NPM Change | ⇒ | Unit Tests JavaScript Repository Language & Strings NPM Change |
done, but can we do it finally in a separate PR?
Sure, I wanted to see what's the real impact on the npm ci with the additional fetch/unzip/minification of the files...
Should we not load it through npm https://github.com/mklkj/tinymce-i18n?
Should we not load it through npm https://github.com/mklkj/tinymce-i18n?
Personally I'm against depending on a random developer for something that essentially is done in the same way: https://github.com/mklkj/tinymce-i18n/blob/a62cd4a29fe10d85aaefe6062abd10fc6cbfd938/update.sh#L3
FWIW maybe you can create a tinyMCE-languages under Joomla-projects and I can create a similar automation (the point here is security, ownership, bus factor, etc). But if people are ok with pulling random packages then I can change the nom-tools to use that package...
I think we should move this to https://github.com/joomla/core-translations and download directly from upstream should be preferred instead of downloading from a random source.
I think we should move this to https://github.com/joomla/core-translations and download directly from upstream should be preferred instead of downloading from a random source.
If this is the decision then create a v5 branch (or call it whatever you like) in the core-translations repo and I will patch things there and correct the PR here
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-06 22:20:02 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
?
|
||
@HLeithner @Hackwar can someone approve the node version bump to v18 on the drone for v5?
FWIW v16 (currently used) will be EOL by the time v5 will be released: https://github.com/nodejs/Release/blob/main/schedule.svg