Joomla! Issue Tracker | Joomla! CMS #40414 - [4.3] Backporting changes from framework Input/Cookie class to CMS class

? bug PR-4.3-dev

Fixed in Code Base
21 Apr 2023
Medium
Build: 4.3-dev
# 40414
Diff
Hackwar:4.3-input

Pending

User tests: Successful: Unsuccessful:

Hackwar
19 Apr 2023

Pull Request for Issue #40412 .

Summary of Changes

This PR backports several bugfixes from the frameworks Input/Cookie class to the CMS class, making the classes compatible. This fixes the issue of the languagefilter not being able to set the cookie. The original issue is, that our base class for our application, AbstractWebApplication, defines the Input object as the framework class, while the child classes use the CMS class instead.

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

e33f299 19 Apr 2023

Backporting changes from framework Input/Cookie class to CMS class

joomla-cms-bot - change - 19 Apr 2023

Category

⇒

Libraries

Hackwar - open - 19 Apr 2023

Hackwar - change - 19 Apr 2023

Status

New

⇒

Pending

bayareajenn - test_item - 21 Apr 2023 - Tested successfully

bayareajenn - comment - 21 Apr 2023

I have tested this item ✅ successfully on e33f299

Because there were no test instructions, I went around looking at other links to determine what and how I was supposed to test. Ultimately I applied the patch, added another language, changed Session to Year in the Language Filter Plugin. Tested on the frontend with no error. Thanks.