Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40386] - Improve system tests descriptions

? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
14 Apr 2023

Unifies the test descriptions. The describe text should always be:

Test that the {component name} {view name} view

While the description of the test itself should be a continuation of the description text like:

can {the tests which are performed}

Both texts should be possible to concat so a meaningful sentence will be built. Because these texts will be displayed in cypress like:
image

avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2023
Category ⇒ JavaScript Unit Tests
avatar laoneo laoneo - open - 14 Apr 2023
avatar laoneo laoneo - change - 14 Apr 2023
Status New ⇒ Pending
avatar laoneo laoneo - change - 14 Apr 2023
The description was changed
avatar laoneo laoneo - edited - 14 Apr 2023
avatar laoneo
laoneo - comment - 14 Apr 2023

@brianteeman can you have a look here if I screwed up something?

avatar brianteeman
brianteeman - comment - 14 Apr 2023

@laoneo lol - I was going to take a look at all of this today. Looks like there might still be a few tweaks needed. setting up my pc for tests and then will post back shortly

8619023 14 Apr 2023 avatar laoneo mail
avatar laoneo laoneo - change - 14 Apr 2023
Labels Added: ? PR-4.4-dev
avatar laoneo
laoneo - comment - 14 Apr 2023

@sandewt thanks for the hint, changed it

avatar brianteeman
brianteeman - comment - 14 Apr 2023

'can create a article'
==>
'can create an article'

4b15b0c 14 Apr 2023 avatar laoneo an
667f835 14 Apr 2023 avatar laoneo a
avatar brianteeman brianteeman - test_item - 14 Apr 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Apr 2023

I have tested this item ✅ successfully on 41e01f1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40386.

avatar brianteeman
brianteeman - comment - 14 Apr 2023

These text patterns should be documented

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40386.

77fbdfd 15 Apr 2023 avatar laoneo send
avatar sandewt
sandewt - comment - 15 Apr 2023

joomla-cms/tests/System/integration/site/components/com_users/Registration.cy.js

Line 17 in 77fbdfd

it('testing registration form for test user through menu item', () => {

Suggestion:

it('testing registration form for a test user through a menu item', () => {

avatar sandewt
sandewt - comment - 15 Apr 2023

it('can show.., and it('can display... are both used.
Preference? Or leave it that way?

avatar laoneo
laoneo - comment - 17 Apr 2023

Better to use display

avatar MacJoom MacJoom - change - 17 Apr 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-04-17 08:55:06
Closed_By ⇒ MacJoom
avatar MacJoom MacJoom - close - 17 Apr 2023
avatar MacJoom MacJoom - merge - 17 Apr 2023
avatar sandewt
sandewt - comment - 17 Apr 2023

Thanks all

Add a Comment

Login with GitHub to post a comment