PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar nikosdion
nikosdion
9 Apr 2023

Pull Request for Issue #40311 .

Summary of Changes

Added shebang to cli/joomla.php and changed its file mode to 0755, making it executable.

Testing Instructions

Using Linux, macOS, WSL2 on Windows, or any other UNIX-style OS using Bash, ZSH, Fish or any other command line shell which supports shebangs (#!) to resolve execution of text files try running the Joomla CLI application directly:

cli/joomla.php -V

Actual result BEFORE applying this Pull Request

You get an error, e.g. when the file is not executable:

zsh: permission denied: cli/joomla.php

or when the file is executable:

cli/joomla.php: line 1: ?php: No such file or directory
cli/joomla.php: line 3: /Applications: is a directory
cli/joomla.php: line 4: CODE_OF_CONDUCT.md: command not found
cli/joomla.php: line 5: CODE_OF_CONDUCT.md: command not found
cli/joomla.php: line 6: syntax error near unexpected token `('
cli/joomla.php: line 6: ` * @copyright  (C) 2017 Open Source Matters, Inc. <https://www.joomla.org>'

Expected result AFTER applying this Pull Request

Joomla CLI runs correctly (note that the version number and debug mode reported may differ):

Joomla! 4.2.9 (debug: Yes)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar nikosdion nikosdion - open - 9 Apr 2023
avatar nikosdion nikosdion - change - 9 Apr 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2023
Category CLI
avatar HLeithner
HLeithner - comment - 10 Apr 2023

sorry to say but that path is wrong it has to be #!/usr/bin/env php and not /user/bin/env php

avatar nikosdion nikosdion - change - 10 Apr 2023
Labels Added: PR-4.3-dev
avatar nikosdion
nikosdion - comment - 10 Apr 2023

Ah, the perils of doing commits using an iPad.

avatar nikosdion
nikosdion - comment - 10 Apr 2023

BTW I did fix the typo

avatar laoneo laoneo - change - 11 Apr 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-04-11 06:08:01
Closed_By laoneo
Labels Added: PR-4.4-dev
Removed: PR-4.3-dev
avatar laoneo laoneo - close - 11 Apr 2023
avatar laoneo laoneo - merge - 11 Apr 2023
avatar laoneo
laoneo - comment - 11 Apr 2023

Thanks!

avatar nikosdion
nikosdion - comment - 11 Apr 2023

Thank you for the merge!

Add a Comment

Login with GitHub to post a comment