Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40350] - Fix disabled select background

? NPM Resource Changed bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
9 Apr 2023

Pull Request for Issue #40349 .

Summary of Changes

Remove the dropdown icon from the disabled select elements

Testing Instructions

Follow the issue

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@heelc29 here you go

avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2023
Category ⇒ Repository NPM Change
avatar dgrammatiko dgrammatiko - open - 9 Apr 2023
avatar dgrammatiko dgrammatiko - change - 9 Apr 2023
Status New ⇒ Pending
avatar brianteeman
brianteeman - comment - 9 Apr 2023

also see #40030

avatar heelc29 heelc29 - test_item - 9 Apr 2023 - Tested successfully
avatar heelc29
heelc29 - comment - 9 Apr 2023

I have tested this item ✅ successfully on e2ea7a9

You're fast. Thanks.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40350.

avatar heelc29
heelc29 - comment - 9 Apr 2023

also see #40030

I haven't seen ?

avatar dgrammatiko
dgrammatiko - comment - 9 Apr 2023

@brianteeman the PR also fixes #40030

avatar richard67 richard67 - test_item - 9 Apr 2023 - Tested successfully
avatar richard67
richard67 - comment - 9 Apr 2023

I have tested this item ✅ successfully on e2ea7a9

Fixes #40349 and #40030 .

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40350.

avatar richard67 richard67 - change - 9 Apr 2023
Status Pending ⇒ Ready to Commit
Labels Added: NPM Resource Changed bug PR-4.3-dev
avatar richard67
richard67 - comment - 9 Apr 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40350.

avatar dgrammatiko
dgrammatiko - comment - 10 Apr 2023

@obuisard should this be considered a RB? It's due to upstream changes in the BS5.2.3

avatar obuisard
obuisard - comment - 10 Apr 2023

@obuisard should this be considered a RB? It's due to upstream changes in the BS5.2.3

I do not consider it a release blocker, but since it is an issue due to the Bootstrap update, I will include it to the final build.

avatar obuisard obuisard - close - 10 Apr 2023
avatar obuisard obuisard - merge - 10 Apr 2023
avatar obuisard obuisard - change - 10 Apr 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-04-10 15:15:42
Closed_By ⇒ obuisard
Labels Added: ?
avatar obuisard
obuisard - comment - 10 Apr 2023

Thank you Dimitris @dgrammatiko for the PR

avatar brianteeman
brianteeman - comment - 10 Apr 2023

Shouldn't a similar PR have been made for cassiopeia?

avatar dgrammatiko
dgrammatiko - comment - 10 Apr 2023

Shouldn't a similar PR have been made for cassiopeia?

I don't see any override for the disabled sudo there:
https://github.com/joomla/joomla-cms/blob/4.3-dev/build/media_source/templates/site/cassiopeia/scss/vendor/bootstrap/_custom-forms.scss

but I guess someone needs to check if the :disable styling is correct

avatar obuisard
obuisard - comment - 10 Apr 2023

This is how I see disabled fields in the frontend:

image

The list field is not selectable but looks the same as if options were selectable, so we could improve on that.

Add a Comment

Login with GitHub to post a comment