[#40328] - [4.4] Rebuild module Breadcrumbs with new Joomla 4 structure
- Fixed in Code Base
- 25 Apr 2023
- Medium
- Build: 4.4-dev
- # 40328
- Diff
- sandewt:patch-11
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Rebuild mod_breadcrumbs with new Joomla 4 structure
-
The method
setSeparatorhas beendroppeddeprecated, it was not used in J4. (A nice feature in itself.) -
The function
public static function getListbecomespublic function getBreadcrumbs(non-static) -
The function
public static function getHomebecomespublic function getHomeItem(non-static) -
A system test has been added (Cypress)
Testing Instructions
- Code review
- System test
- Just try to use it as usual
Actual result BEFORE applying this Pull Request
- Module works
Expected result AFTER applying this Pull Request
- Module works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
ping @laoneo
joomla-cms-bot
- | Category | ⇒ | Modules Front End JavaScript Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
PR-4.4-dev
|
||
| Labels |
Added:
?
|
||
In my php editor, appears the following message in the Dispatcher.php file:
Method 'getBreadcrumbs' not found in \Joomla\Database\DatabaseAwareInterface|null|\stdClass
Method 'getHomeItem' not found in \Joomla\Database\DatabaseAwareInterface|null|\stdClass
This error disappears when I change in the BreadcrumbsHelper.php file:
class BreadcrumbsHelper
{
to:
use Joomla\Database\DatabaseAwareInterface;
use Joomla\Database\DatabaseAwareTrait;
class BreadcrumbsHelper implements DatabaseAwareInterface
{
use DatabaseAwareTrait;
The database is not called in this file. So that's why I don't understand this message.
What to do? Ignore notification or what is desirable?
Also, I do not think this is needed inside this helper.
Agree, but that means that the underlying code of the Dispatcher.php is not quite correct. And so it is a point of attention.
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-25 05:53:02 |
| Closed_By | ⇒ | laoneo |
Thanks!
I hope you guys do continue the good work and convert more modules. This is very important work for the future. Especially when system tests are added...
I like to do that. As soon as I have time, I will convert a new module / plugin.
Drone fails
AssertionError: Timed out retrying after 4000ms: