[#40307] - [4.3] Reset banner statistics in copy
- Fixed in Code Base
- 5 May 2023
- Medium
- Build: 4.3-dev
- # 40307
- Diff
- chmst:banner-reset-counter
User tests: Successful: Unsuccessful:
Pull Request for Issue #40262
Summary of Changes
Set clicks and impmade to 0 when a banner is saved as copy
Testing Instructions
Copy a banner and check that values for clicks and impressions are set to 0
Actual result BEFORE applying this Pull Request
see #40262
Expected result AFTER applying this Pull Request
clicks and impressions for a ccopy is 0
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
I have tested this item
When using the "Save as Copy" button in the edit view, the PR works well.
But when using batch copy in the list view to copy a banner to another category, the statistics are not reset.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40307.
| Labels |
Added:
bug
PR-4.3-dev
?
|
||
Clicks and Impressions are now initialised in batchCopy.
Open: Is this B/C break?
If the client is changed, clicks and impressions remain unchanged. Correct?
_
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
I have tested this item
I've tested both the "save & copy" button in the edit view and the batch copy of one and of multiple banners to another category.
In all cases the clicks and impressions were reset.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40307.
@viocassel Could you test again, this time also the batch copy of banners to another category? Thanks in advance.
I have tested this item
@richard67
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40307.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40307.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-05 23:39:21 |
| Closed_By | ⇒ | obuisard |
I have tested this item✅ successfully on e4d3c97
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40307.