No Code Attached Yet bug
avatar joomlaphp
joomlaphp
2 Apr 2023

Steps to reproduce the issue

Create a new module, banner position and a new button. Example. Click <a class="btn btn-success" href="#!">Get started</a> and it will color when active: #fff; It was supposed to be but it uses the color of the Cassiopeia theme.

a:focus, a:hover {
    color: var(--cassiopeia-color-hover);
}

Same issue with the others except the default primary.

Expected result

banner-position

Actual result

System information (as much as possible)

Additional comments

avatar joomlaphp joomlaphp - open - 2 Apr 2023
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Apr 2023
avatar chmst
chmst - comment - 2 Apr 2023

I cannot replicate this on a fresh installation. You have changed some colours in your template?

avatar Hittitech
Hittitech - comment - 2 Apr 2023

i would love to work on this issue .Can you please assign it to me?

avatar joomlaphp
joomlaphp - comment - 3 Apr 2023

I cannot replicate this on a fresh installation. You have changed some colours in your template?

No, the default

avatar richard67
richard67 - comment - 3 Apr 2023

i would love to work on this issue .Can you please assign it to me?

@Hittitech We normally don't assign issues here (except if something special to be handled by a maintainer). If you want to work on it, just start and make a pull request when you have something ready. Of course you should have tested your changes before submitting a pull request. Then, when it is submitted, it will need 2 additional human tests (i.e. not by you).

avatar joomlaphp joomlaphp - change - 3 Apr 2023
The description was changed
avatar joomlaphp joomlaphp - edited - 3 Apr 2023
avatar joomlaphp joomlaphp - change - 3 Apr 2023
The description was changed
avatar joomlaphp joomlaphp - edited - 3 Apr 2023
avatar joomlaphp joomlaphp - change - 3 Apr 2023
The description was changed
avatar joomlaphp joomlaphp - edited - 3 Apr 2023
avatar dgrammatiko
dgrammatiko - comment - 6 Apr 2023

This is an easy, change

&:hover,
&:focus {
color: var(--cassiopeia-color-hover);
}

to

  &:not([.btn]):hover,
  &:not([.btn]):focus {
    color: var(--cassiopeia-color-hover);
  }
avatar joomlaphp
joomlaphp - comment - 6 Apr 2023

Thank you, I hope they add this to the core file.

avatar richard67 richard67 - change - 6 Apr 2023
Labels Added: bug
avatar richard67 richard67 - labeled - 6 Apr 2023
avatar richard67
richard67 - comment - 6 Apr 2023

@joomlaphp The file mentioned by @dgrammatiko is used to build the template.css file. Where did you try the change? It will not help just to put the change suggested by @dgrammatiko into a user.css file. You have to recompile the template.css after having made the change in the file which he has mentioned.

avatar joomlaphp
joomlaphp - comment - 6 Apr 2023

@joomlaphp The file mentioned by @dgrammatiko is used to build the template.css file. Where did you try the change? It will not help just to put the change suggested by @dgrammatiko into a user.css file. You have to recompile the template.css after having made the change in the file which he has mentioned.

Ok it's done now, thank you very much.

avatar joomlaphp
joomlaphp - comment - 18 Apr 2023

Has this been fixed with 4.3.0 Stable release?
Thanks

avatar brianteeman
brianteeman - comment - 18 Apr 2023

As the issue is still open then I would assume not

avatar sandewt
sandewt - comment - 20 Apr 2023

Pr please test #40435

avatar richard67 richard67 - close - 20 Apr 2023
avatar richard67
richard67 - comment - 20 Apr 2023

Closing as having a pull request. Please test #40435 . Thanks in advance.

avatar richard67 richard67 - change - 20 Apr 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-04-20 12:04:41
Closed_By richard67

Add a Comment

Login with GitHub to post a comment