Joomla! Issue Tracker | Joomla! CMS #40297 - [4.3] Guided Tours remove broken code for creation of basic step

? Language Change bug PR-4.3-dev

Fixed in Code Base
11 Aug 2023
Medium
Build: 4.3-dev
# 40297
Diff
heelc29:4.3/com_guidedtours/tour-new/sql-error

Pending

Pending continuous-integration/drone/pr Build is pending Details

User tests: Successful: Unsuccessful:

heelc29
2 Apr 2023

Summary of Changes

Fix the creation of the basic step when creating a new tour

joomla-cms/administrator/components/com_guidedtours/src/Model/TourModel.php

Lines 82 to 95 in 338a940

    
           // Create default step for new tour 
        
           if ($result && $input->getCmd('task') !== 'save2copy' && $this->getState($this->getName() . '.new')) { 
        
               $tourId = (int) $this->getState($this->getName() . '.id'); 
        
               $table = $this->getTable('Step'); 
        
               $table->id          = 0; 
        
               $table->title       = 'COM_GUIDEDTOURS_BASIC_STEP'; 
        
               $table->description = ''; 
        
               $table->tour_id     = $tourId; 
        
               $table->published   = 1; 
        
               $table->store(); 
        
           }

Testing Instructions

Create a new tour

Actual result BEFORE applying this Pull Request

The new tour does not contain steps

database errors:

Expected result AFTER applying this Pull Request

The tour saves properly, and when going to the steps page, the user is prompted to create a step.

Link to documentations

Please select:

No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed

ecc74a5 2 Apr 2023

[4.3] Fix the creation of the basic step when creating a new tour

joomla-cms-bot - change - 2 Apr 2023

Category

⇒

Administration

heelc29 - open - 2 Apr 2023

heelc29 - change - 2 Apr 2023

Status

New

⇒

Pending

richard67 - comment - 2 Apr 2023

@heelc29 I don't get these database errors when creating a new tour on a clean, current 4.3-dev branch after a new installation of Joomla.

Could you describe in detail what you have done to get these errors? And what's your PHP and your database server type (MySQL or MariaDB) and version?

heelc29 - comment - 2 Apr 2023

Could you describe in detail what you have done to get these errors?

@richard67 I get it while debugging (xDebug) why no step is created. The exception is caught by the table class but you can check it also with this code

if (!$table->store()) {
    throw new \Exception(implode("\n", $table->getErrors()), 500);
}

And what's your PHP and your database server type (MySQL or MariaDB) and version?

richard67 - test_item - 2 Apr 2023 - Tested successfully

richard67 - comment - 2 Apr 2023

I have tested this item ✅ successfully on ecc74a5

I can confirm that without this PR, the basic step doesn't get created when using "save" or "save and new", while it gets created with this PR applied.

I also can confirm that the columns handled by this PR here indeed don't have default values, so they should be set when creating a new record.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40297.}

obuisard - comment - 2 Apr 2023

Now, I am not sure we really need a basic step here....

chmst - comment - 21 Apr 2023

Following the instructions I can confirm that the mentioned exceptions are resolved and an first step is stored. But there is still the Message

Column 'ordering' cannot be null

heelc29 - comment - 4 May 2023

Column 'ordering' cannot be null

This column should have a default value ?

joomla-cms/installation/sql/mysql/extensions.sql

Line 986 in 3209f68

`ordering` int NOT NULL DEFAULT 0,

Now, I am not sure we really need a basic step here....

@obuisard We can also delete the broken code ...

obuisard - comment - 4 May 2023

I would just remove the code that is never executed rather than try fixing it. To me, it does not help to have a pre-installed step when a tour is created.
Right now, the behavior users get is that no step is created when creating a new tour.
We should just leave it like that (the behavior) and remove the code that was supposed to create a new step but is never reached.

639e9bf 20 May 2023

Merge branch 4.3-dev into com_guidedtours/basic-step

92f28cf 20 May 2023

[4.3] Remove broken code for creation of basic step

heelc29 - change - 20 May 2023

Title

…

[4.3] Guided Tours ~~fix the creation of the basic step when creating a new tour~~

[4.3] Guided Tours remove broken code for creation of basic step

heelc29 - edited - 20 May 2023

joomla-cms-bot - change - 20 May 2023

Category

Administration

⇒

Administration Language & Strings

heelc29 - change - 20 May 2023

Labels

Added: bug PR-4.3-dev

heelc29 - comment - 20 May 2023

remove the code that was supposed to create a new step but is never reached

@obuisard PR updated

obuisard - comment - 20 May 2023

remove the code that was supposed to create a new step but is never reached

@obuisard PR updated

Thank you so much @heelc29, really appreciated.

90a500c 26 May 2023

Merge branch '4.3-dev' into 4.3/com_guidedtours/tour-new/sql-error

heelc29 - change - 26 May 2023

Labels

Added: Language Change

0ce5c6b 20 Jun 2023

Merge branch '4.3-dev' into 4.3/com_guidedtours/tour-new/sql-error

khu5h1 - test_item - 25 Jun 2023 - Tested successfully

khu5h1 - comment - 25 Jun 2023

I have tested this item ✅ successfully on 0ce5c6b

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40297.}

obuisard - test_item - 10 Aug 2023 - Tested successfully

obuisard - comment - 10 Aug 2023

I have tested this item ✅ successfully on 0ce5c6b

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40297.}

obuisard - change - 10 Aug 2023

The description was changed

obuisard - edited - 10 Aug 2023

Quy - change - 10 Aug 2023

Status

Pending

⇒

Ready to Commit

Quy - comment - 10 Aug 2023

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40297.}

6c4b063 10 Aug 2023

Merge branch '4.3-dev' into 4.3/com_guidedtours/tour-new/sql-error

Quy - change - 10 Aug 2023

Labels

Added: ?

f299b49 11 Aug 2023

Merge branch '4.3-dev' into 4.3/com_guidedtours/tour-new/sql-error

sdwjoomla - close - 11 Aug 2023

sdwjoomla - merge - 11 Aug 2023

sdwjoomla - change - 11 Aug 2023

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2023-08-11 13:55:55
Closed_By		⇒	sdwjoomla

sdwjoomla - comment - 11 Aug 2023

Thanks @heelc29

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#40297] - [4.3] Guided Tours remove broken code for creation of basic step

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Add a Comment

	// Create default step for new tour
	if ($result && $input->getCmd('task') !== 'save2copy' && $this->getState($this->getName() . '.new')) {
	$tourId = (int) $this->getState($this->getName() . '.id');

	$table = $this->getTable('Step');

	$table->id = 0;
	$table->title = 'COM_GUIDEDTOURS_BASIC_STEP';
	$table->description = '';
	$table->tour_id = $tourId;
	$table->published = 1;

	$table->store();
	}