User tests: Successful: Unsuccessful:
This PR removes language strings marked for deprecation in 5.0
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Administration Language & Strings |
Status | New | ⇒ | Pending |
Title |
|
did @richard67 removed the files from #39431 already in a 5.0 PR?
did @richard67 removed the files from #39431 already in a 5.0 PR?
@HLeithner No, I haven't done that yet. Shall I do that?
yes please
@HLeithner See PR #40302 .
Labels |
Added:
Language Change
PR-5.0-dev
|
I have tested this item
Code review: I can confirm that this PR covers all deprecations for 5.0 in language files which have a corresponding deprecation comment.
@brianteeman since @richard67 brings this up in the other PR could you create a PR against the 5.0 branch in the manual please?
joomla/Manual#28 Add a section to the b/c incompatible file
with a pr against a pr?
with a pr against a pr?
it's the 5.0 branch in the manual repo
@brianteeman since @richard67 brings this up in the other PR could you create a PR against the 5.0 branch in the manual please?
joomla/Manual#28 Add a section to the b/c incompatible file
@brianteeman Harald means the https://github.com/joomla/Manual/blob/5.0/migrations/44-50/removed-backward-incompatibility.md file.
Thanks @richard67
@brianteeman Now you only need to adapt the last 2 check boxes in the "Link to documentations" section of the description. The "Pull Request link for manual.joomla.org: " should be checked, and the link to joomla/Manual#101 should be added at the end, and the other checkbox below that should be unchecked.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-08 12:00:26 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
?
Removal
|
@HLeithner there are a few more strings marked for removal in #39374 which related to
build\media_source\com_users\js\admin-users-mail.es6.js
but this file was put back in #39431 and marked to be removed in 5.0. Is that js still being removed in 5.0? If not then I should remove/change the language string comment