Language Change ? PR-5.0-dev Removal Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Apr 2023

This PR removes language strings marked for deprecation in 5.0

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2023
Category Administration Language & Strings
avatar brianteeman brianteeman - open - 2 Apr 2023
avatar brianteeman brianteeman - change - 2 Apr 2023
Status New Pending
avatar brianteeman brianteeman - change - 2 Apr 2023
Title
5 strings
[5.0] remove deprecated strings
avatar brianteeman brianteeman - edited - 2 Apr 2023
avatar brianteeman
brianteeman - comment - 2 Apr 2023

@HLeithner there are a few more strings marked for removal in #39374 which related to build\media_source\com_users\js\admin-users-mail.es6.js but this file was put back in #39431 and marked to be removed in 5.0. Is that js still being removed in 5.0? If not then I should remove/change the language string comment

avatar HLeithner
HLeithner - comment - 2 Apr 2023

did @richard67 removed the files from #39431 already in a 5.0 PR?

avatar richard67
richard67 - comment - 2 Apr 2023

did @richard67 removed the files from #39431 already in a 5.0 PR?

@HLeithner No, I haven't done that yet. Shall I do that?

avatar HLeithner
HLeithner - comment - 2 Apr 2023

yes please

avatar richard67
richard67 - comment - 2 Apr 2023

@HLeithner See PR #40302 .

avatar brianteeman brianteeman - change - 2 Apr 2023
Labels Added: Language Change PR-5.0-dev
avatar richard67 richard67 - test_item - 2 Apr 2023 - Tested successfully
avatar richard67
richard67 - comment - 2 Apr 2023

I have tested this item successfully on 996c306

Code review: I can confirm that this PR covers all deprecations for 5.0 in language files which have a corresponding deprecation comment.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40296.

avatar HLeithner
HLeithner - comment - 2 Apr 2023

@brianteeman since @richard67 brings this up in the other PR could you create a PR against the 5.0 branch in the manual please?

joomla/Manual#28 Add a section to the b/c incompatible file

avatar brianteeman
brianteeman - comment - 2 Apr 2023

with a pr against a pr?

avatar HLeithner
HLeithner - comment - 2 Apr 2023

with a pr against a pr?

it's the 5.0 branch in the manual repo

avatar richard67
richard67 - comment - 2 Apr 2023

@brianteeman since @richard67 brings this up in the other PR could you create a PR against the 5.0 branch in the manual please?

joomla/Manual#28 Add a section to the b/c incompatible file

@brianteeman Harald means the https://github.com/joomla/Manual/blob/5.0/migrations/44-50/removed-backward-incompatibility.md file.

avatar brianteeman
brianteeman - comment - 2 Apr 2023
avatar richard67
richard67 - comment - 2 Apr 2023

@brianteeman Now you only need to adapt the last 2 check boxes in the "Link to documentations" section of the description. The "Pull Request link for manual.joomla.org: " should be checked, and the link to joomla/Manual#101 should be added at the end, and the other checkbox below that should be unchecked.

avatar brianteeman brianteeman - change - 8 Sep 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-09-08 12:00:26
Closed_By brianteeman
Labels Added: ? Removal
avatar brianteeman brianteeman - close - 8 Sep 2023

Add a Comment

Login with GitHub to post a comment