PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
2 Apr 2023

Pull Request for Issue # .

Summary of Changes

Now as my 2 pull requests (PR's) #40280 and #40281 for removing obsolete code for updating from 3.10 to 4.x have been merged, the "postflight" method in file "script.php" does not do anymore anything.

However, this method is public and called from the update model of the Joomla Update component after the database updates, so it should not be deleted but be changed for the new major version 5.

This is what this PR here does.

In addition, it adds a comment as placeholder for code to be added when necessary.

Testing Instructions

Code review: Check that the "postflight" method in file "script.php" in the 5.0-dev branch does not do anything after checking the action and the version. Check that this PR changes the version number in the version_compare in the right way and the added placeholder comment is right.

Actual result BEFORE applying this Pull Request

"postflight" method still checks for major version 4 and does not really do anything.

Expected result AFTER applying this Pull Request

"postflight" method checks for major version 5 and has a comment which shows where to add code when necessary so the method will really do something.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2023
Category Administration com_admin
avatar richard67 richard67 - open - 2 Apr 2023
avatar richard67 richard67 - change - 2 Apr 2023
Status New Pending
avatar richard67 richard67 - change - 2 Apr 2023
The description was changed
avatar richard67 richard67 - edited - 2 Apr 2023
avatar HLeithner HLeithner - close - 2 Apr 2023
avatar HLeithner HLeithner - merge - 2 Apr 2023
avatar HLeithner HLeithner - change - 2 Apr 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-04-02 13:21:12
Closed_By HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner
HLeithner - comment - 2 Apr 2023

thanks

Add a Comment

Login with GitHub to post a comment