User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Now as my 2 pull requests (PR's) #40280 and #40281 for removing obsolete code for updating from 3.10 to 4.x have been merged, the "postflight" method in file "script.php" does not do anymore anything.
However, this method is public and called from the update model of the Joomla Update component after the database updates, so it should not be deleted but be changed for the new major version 5.
This is what this PR here does.
In addition, it adds a comment as placeholder for code to be added when necessary.
Code review: Check that the "postflight" method in file "script.php" in the 5.0-dev branch does not do anything after checking the action and the version. Check that this PR changes the version number in the version_compare in the right way and the added placeholder comment is right.
"postflight" method still checks for major version 4 and does not really do anything.
"postflight" method checks for major version 5 and has a comment which shows where to add code when necessary so the method will really do something.
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
Category | ⇒ | Administration com_admin |
Status | New | ⇒ | Pending |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-02 13:21:12 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
PR-5.0-dev
|
thanks