[#40293] - [5.0] Chore/disable polyfill php 7.0 - 8.1
- Fixed in Code Base
- 2 Apr 2023
- Medium
- Build: 5.0-dev
- # 40293
- Diff
- HLeithner:chore/disable-polyfill-php-7-81
User tests: Successful: Unsuccessful:
We don't need the symfony polyfills for php < 8.2 since the php minimum requirement is 8.1
This PR is based on #40292
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_content com_contenthistory Language & Strings Templates (admin) JavaScript NPM Change External Library Composer Change Libraries |
| Status | New | ⇒ | Pending |
The changes look ok but please - one commit per issue. Nothing is really testable when you lump so many things into one pr
I try to reduce merge conflicts, pr based on other prs is a common case, and as soon as the other pr is merged this one get cleared automatically.
I dont see how there would have been a merge conflict - even so it makes the pr hard to review and thats why mistakes happen when there are so many changes
| Category | Unit Tests Repository Administration com_content com_contenthistory Language & Strings Templates (admin) JavaScript NPM Change External Library Composer Change Libraries | ⇒ | External Library Composer Change |
| Labels |
Added:
?
Language Change
Composer Dependency Changed
NPM Resource Changed
PR-5.0-dev
|
||
I dont see how there would have been a merge conflict - even so it makes the pr hard to review and thats why mistakes happen when there are so many changes
do you understand it now? after merging the upmerge pr, this PR is clean and has only the commits related for this pr
I understood it before - I still dont think it is good practice.
Also due to language issues I read your comment "based on" to mean the code in this pr is based on the same techniques in this other PR.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-02 09:01:17 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Removed:
?
Language Change
NPM Resource Changed
|
||
Was just preparing my tests.
Test was successful, PR solves the problem.
121 changed files ?