User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) removes the method "addUserAuthProviderColumn" and calls to it from file "administrator/components/com_admin/script.php".
The method once had been added with version 4.1.1 for a security fix with this commit f49c451 because there was a similar security fix made at the same time for 3.10, so that new column in the users table could already be there, depending on the update history of the 4.1.1 site. Therefore it was not possible to do that with an update SQL at that time, and so the method was added. Nowadays you could do that with an update SQL and the /** CAN FAIL **/
installer hint.
The PR is one in a sequence of PR's for removing obsolete actions from script.php which are not relevant anymore because updates to 5.x will have to be done from a 4.4 version, like it is now with 4.x from 3.10.
Code review: Make sure that the removed method is not called anywhere else and that it does something which is definitely not needed when updating from 4.4 to 5.
Optional real test: Make sure that updating the latest 4.4-dev nightly build to the update package created by drone works when using the upload & update method.
Obsolete code for adding the authProvider
column to the #__users
table when updating from 3.10 or 4.1.0 or an older 4.x is present in script.php.
Obsolete code for adding the authProvider
column to the #__users
table when updating from 3.10 or 4.1.0 or an older 4.x to 4.1.1 or later is not present anymore in script.php.
Updating from a 4.4-dev nightly build works.
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
Category | ⇒ | Administration com_admin |
Status | New | ⇒ | Pending |
Labels |
Added:
PR-5.0-dev
|
Can you please resolve the conflicts?
@HLeithner Was already done when you typed :-)
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-30 19:13:18 |
Closed_By | ⇒ | HLeithner |
thanks
Can you please resolve the conflicts?