Feeling Lucky
?
NPM Resource Changed
PR-4.3-dev
[#40230] - Fix compatibility break in validation.js
- Fixed in Code Base
- 30 Mar 2023
- Medium
- Build: 4.3-dev
- # 40230
- Diff
- Fedik:validator-bc-fix
User tests: Successful: Unsuccessful:
Summary of Changes
As result of #39350 it become impossible to use validation over non <form> element.
Hovewer some extensions use this feature to validate form "per section".
Testing Instructions
Apply patch. Run npm install
Open a form for "New article".
In Browser console, run 2 commands (one by one):
document.formvalidator.isValid(window['item-form']);
document.formvalidator.isValid(window['item-form'].parentElement);Actual result BEFORE applying this Pull Request
First command executed, and you get a validation message.
Second command throws an error
Expected result AFTER applying this Pull Request
Both commands works, and shows validation message
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
obuisard
- comment
- 30 Mar 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40230.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.3-dev
|
||
Quy
- comment
- 30 Mar 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40230.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-30 19:00:09 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
NPM Resource Changed
|
||
I have tested this item✅ successfully on 819f565
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40230.