[#40225] - Hide the filter_tag parameter in URL
- Fixed in Code Base
- 5 May 2023
- Medium
- Build: 4.3-dev
- # 40225
- Diff
- QuonXF:QuonXF-patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #36546 and #34527.
Fix for SEF-URL (search engines friendly url), hides the filter_tag parameter from the URL when the menu item is created with category type and filtering by tag or tags.
Actual result BEFORE applying this Pull Request
https://site.local/menu?filter_tag[0]=X?filter_tag[1]=Y
https://site.local/menu/itemA?filter_tag[0]=X
https://site.local/menu/itemA/subitemA?filter_tag[0]=X
Expected result AFTER applying this Pull Request
https://site.local/menu
https://site.local/menu/itemA
https://site.local/menu/itemA/subitemA
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
There is a menu item with the blog category type and with a selection by tag, as well as a sub menu item with the same parameters.
Before the patch:
https://site.local/menu?filter_tag[0]=XXX
https://site.local/menu/itemA?filter_tag[0]=XXX
https://site.local/menu/itemA/subitemA?filter_tag[0]=XXX
After the patch:
https://site.local/menu
https://site.local/menu/itemA
https://site.local/menu/itemA/subitemA
But if you already have a menu item without a filter?
Then nothing will happen to him.
If the menu was created without filtering by tag, then when getting the menu item
$item = $this->router->menu->getItem($query['Itemid'])
the filter_tag parameter will be missing and check
if ($item->query['filter_tag'] === $query['filter_tag'])
will return false and will not execute
unset($query['filter_tag'])
When SEF-URL (search engines friendly url) is disabled, everything will be in place.
With tag filtering:
index.php?option=com_content&view=category&layout=blog&id=145&filter_tag[0]=2&Itemid=401
Without tag filtering:
index.php?option=com_content&view=category&layout=blog&id=145&Itemid=403
| Title |
|
||||||
| Labels |
Added:
PR-4.3-dev
|
||
Added a check for the existence of the filter_tag variable by the selected item, and added a check for query for the presence of a filter_tag.
I have tested this item
Before Patch: https://bugsfun.jdayusa.com/site6/index.php/de/tagged?filter_tag[0]=2
After Patch: https://bugsfun.jdayusa.com/site6/index.php/de/tagged
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40225.
I have tested this item
Thank you for this patch ??
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40225.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40225.
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-05 21:03:05 |
| Closed_By | ⇒ | obuisard |
Surely that is not correct. If you already have a menu item
/menu/category