Feeling Lucky
PR-4.4-dev
[#40224] - [4.4] Introduce local variables to replace repeating method calls
- Fixed in Code Base
- 29 Mar 2023
- Medium
- Build: 4.4-dev
- # 40224
- Diff
- joomdonation:introduce_local_variables
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR introduces local variables $app and $db to replace the repeating calls $this->getApplication() and $this->getDatabase(). phpstorm has a built-in function called Refactor -> Introduce Variable allows us to do this quickly. We do not have a clear rule for this, but I think doing that would make code more cleaner and a little faster.
Testing Instructions
- Use Joomla 4.4
- Apply patch
- Try to login, check on Remember Me checkbox, make sure it is working OK
- Code review would be great, too.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works with cleaner code and a little faster.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.4-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-29 06:14:23 |
| Closed_By | ⇒ | laoneo |
laoneo
- comment
- 29 Mar 2023
Thanks!
I'm not sure if there should be a blank line before the if blocks. Beside that it looks good! Thanks.