Feeling Lucky
?
NPM Resource Changed
bug
PR-4.3-dev
[#40221] - fix: Make schedule-runner work with adblockers
- Fixed in Code Base
- 5 May 2023
- Medium
- Build: 4.3-dev
- # 40221
- Diff
- ditsuke:fix/schedule-runner-beacon
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Adblockers usually block out navigator.sendBeacon since its primary intended use-case is analytics. This PR replaces Scheduler's usage of sendBeacon with fetch.
Ref: #40157
Testing Instructions
nil
Actual result BEFORE applying this Pull Request
Schedule runner doesn't work on browsers with ad-blockers.
Expected result AFTER applying this Pull Request
Schedule runner works on browsers with ad-blockers.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End Plugins |
viocassel
- comment
- 29 Mar 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40221.
| Status | New | ⇒ | Ready to Commit |
alikon
- comment
- 29 Mar 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40221.
| Labels |
Added:
?
NPM Resource Changed
bug
PR-4.3-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-05 02:46:02 |
| Closed_By | ⇒ | sdwjoomla |
sdwjoomla
- comment
- 5 May 2023
thank you ditsuke
I have tested this item✅ successfully on 3ce60ad
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40221.