bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
27 Mar 2023

Summary of Changes

Converts the system plugins to service providers.

Testing Instructions

Do different things like login/logout on the front end, enable debug mode, play around with http headers.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2023
Category Front End Plugins
avatar laoneo laoneo - open - 27 Mar 2023
avatar laoneo laoneo - change - 27 Mar 2023
Status New Pending
avatar laoneo laoneo - change - 27 Mar 2023
Labels Added: PR-4.4-dev
e89377d 27 Mar 2023 avatar laoneo cs
avatar Fedik
Fedik - comment - 27 Mar 2023

@laoneo please keep plugin constructors consistent.

new Plugin($dispatcher, $config, ... other variables)

instead of

new Plugin(... other variables, $dispatcher, $config)

That would be nice :)

avatar laoneo laoneo - change - 27 Mar 2023
Title
Convert system plugins to service provider
[Draft] Convert system plugins to service provider
avatar laoneo laoneo - edited - 27 Mar 2023
ed3df6a 27 Mar 2023 avatar laoneo cs
avatar laoneo
laoneo - comment - 27 Mar 2023

@Fedik changed it

b318181 27 Mar 2023 avatar laoneo cs
avatar Fedik
Fedik - comment - 27 Mar 2023

Thanks! Looks good

avatar laoneo laoneo - change - 27 Mar 2023
Title
[Draft] Convert system plugins to service provider
Convert system plugins to service provider
avatar laoneo laoneo - edited - 27 Mar 2023
bc2e450 27 Mar 2023 avatar laoneo text
avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2023
Category Front End Plugins Administration Language & Strings Libraries Front End Plugins
avatar laoneo laoneo - change - 27 Mar 2023
Labels Added: Language Change
avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2023
Category Front End Plugins Administration Language & Strings Libraries Front End Plugins
avatar laoneo laoneo - change - 31 Mar 2023
Labels Removed: Language Change
avatar laoneo
laoneo - comment - 4 Apr 2023

@joomdonation added your suggestions

avatar joomdonation joomdonation - test_item - 4 Apr 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 4 Apr 2023

I have tested this item successfully on 04cdf1a

Careful code review + tested as much as I can (both for mono language and multilingual website).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40216.

avatar laoneo laoneo - change - 12 Apr 2023
Labels Added: bug
9361a15 20 Apr 2023 avatar laoneo cs
avatar MacJoom MacJoom - change - 9 May 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-09 10:12:04
Closed_By MacJoom
avatar MacJoom MacJoom - close - 9 May 2023
avatar MacJoom MacJoom - merge - 9 May 2023

Add a Comment

Login with GitHub to post a comment