Joomla! Issue Tracker | Joomla! CMS #40194 - Fix incorrect HTML rendering

? PR-4.3-dev

Fixed in Code Base
25 Mar 2023
Medium
Build: 4.3-dev
# 40194
Diff
Fedik:fix40185

Pending

User tests: Successful: Unsuccessful:

Fedik
25 Mar 2023

Pull Request for Issue #40185 .

Summary of Changes

Fixing incorect HTML rendering

Testing Instructions

Please follow #40185

Actual result BEFORE applying this Pull Request

You get double <body> tag

Expected result AFTER applying this Pull Request

There only 1 <body> tag

Link to documentations

Please select:

No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed

0182146 25 Mar 2023

Fix incorrect HTML rendering

joomla-cms-bot - change - 25 Mar 2023

Category

⇒

Administration Templates (admin)

Fedik - open - 25 Mar 2023

Fedik - change - 25 Mar 2023

Status

New

⇒

Pending

Quy - test_item - 25 Mar 2023 - Tested successfully

Quy - comment - 25 Mar 2023

I have tested this item ✅ successfully on 0182146

Before:

<div class="header-dd-item dropdown-item" data-item="1"><!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<?xml encoding="utf-8" ?><html><body><div class="header-item-content dropdown header-tours d-none d-sm-block">
    <button class="dropdown-toggle d-flex align-items-center ps-0 py-0" data-bs-toggle="dropdown" type="button" title="Take a Tour">
        <div class="header-item-icon">
            <span class="icon-map-signs" aria-hidden="true"></span>
        </div>
        <div class="header-item-text">
            Take a Tour        </div>
        <span class="icon-angle-down" aria-hidden="true"></span>
    </button>
    <div class="dropdown-menu dropdown-menu-end">
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="3">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create articles?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="4">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create categories?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="5">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create menus?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="6">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create tags?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="7">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create banners?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="8">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create contacts?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="9">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to enter a news feed?            </button>
                                            <button type="button" class="dropdown-item text-center" data-bs-toggle="modal" data-bs-target="#modGuidedTours-modal">
            Show all tours        </button>
    </div>
</div>
</body></html>
</div>

After:

<div class="header-dd-item dropdown-item" data-item="1"><div class="header-item-content dropdown header-tours d-none d-sm-block">
    <button class="dropdown-toggle d-flex align-items-center ps-0 py-0" data-bs-toggle="dropdown" type="button" title="Take a Tour">
        <div class="header-item-icon">
            <span class="icon-map-signs" aria-hidden="true"></span>
        </div>
        <div class="header-item-text">
            Take a Tour        </div>
        <span class="icon-angle-down" aria-hidden="true"></span>
    </button>
    <div class="dropdown-menu dropdown-menu-end">
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="3">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create articles?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="4">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create categories?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="5">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create menus?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="6">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create tags?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="7">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create banners?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="8">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to create contacts?            </button>
                                <button type="button" class="button-start-guidedtour dropdown-item" data-id="9">
                <span class="icon-map-signs" aria-hidden="true"></span>
                How to enter a news feed?            </button>
                                            <button type="button" class="dropdown-item text-center" data-bs-toggle="modal" data-bs-target="#modGuidedTours-modal">
            Show all tours        </button>
    </div>
</div>

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40194.}

joomdonation - test_item - 25 Mar 2023 - Tested successfully

joomdonation - comment - 25 Mar 2023

I have tested this item ✅ successfully on 0182146

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40194.}

joomdonation - change - 25 Mar 2023

Status

Pending

⇒

Ready to Commit

joomdonation - comment - 25 Mar 2023

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40194.}

Quy - change - 25 Mar 2023

Labels

Added: ? PR-4.3-dev

heelc29 - test_item - 25 Mar 2023 - Tested successfully

heelc29 - comment - 25 Mar 2023

I have tested this item ✅ successfully on 0182146

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40194.}

obuisard - comment - 25 Mar 2023

Thank you guys for looking into it, it does fix the problem.

obuisard - close - 25 Mar 2023

obuisard - merge - 25 Mar 2023

obuisard - change - 25 Mar 2023

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2023-03-25 18:41:52
Closed_By		⇒	obuisard

obuisard - comment - 25 Mar 2023

Thank you, Fedir @Fedik for the fix!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#40194] - Fix incorrect HTML rendering

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Add a Comment