? bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
25 Mar 2023

Pull Request for Issue #40151.

Summary of Changes

This PR modifies the code uses in Category form field to by pass access level check for users with core.admin permission, similar as how we are doing for other field type like https://github.com/joomla/joomla-cms/blob/4.3-dev/administrator/components/com_categories/src/Field/CategoryeditField.php#L214

Testing Instructions

  1. Login using a super users account.
  2. Create a new access level Author, only select Author user group for that access level
  3. Access to Content -> Categories, create a new category, set Access to Author access level above
  4. Access to Content -> Articles, click on Filter Options, look at Categories filter dropdown in search tools

Actual result BEFORE applying this Pull Request

You do not see the category you created above in the categories dropdown. You should see it, as a super user, you should see all categories in the dropdown (same as the categories dropdown when you add new article).

Expected result AFTER applying this Pull Request

You see the category which you created above in the categories filter dropdown, not depend on the access level you set for the category.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2023
Category Libraries
avatar joomdonation joomdonation - open - 25 Mar 2023
avatar joomdonation joomdonation - change - 25 Mar 2023
Status New Pending
avatar joomdonation joomdonation - change - 26 Mar 2023
The description was changed
avatar joomdonation joomdonation - edited - 26 Mar 2023
avatar boddunan
boddunan - comment - 27 Mar 2023

@joomdonation Tested this change and it is working fine. The category form field now shows all categories.

avatar joomdonation
joomdonation - comment - 27 Mar 2023

@boddunan Could you please go to https://issues.joomla.org/tracker/joomla-cms/40193 and report your test result there ?

avatar boddunan boddunan - test_item - 27 Mar 2023 - Tested successfully
avatar boddunan
boddunan - comment - 27 Mar 2023

I have tested this item successfully on c63878c

1. Created new child user group under registered user group
2. Created new access level that allow child user group
3. Created a custom component with category support
4. Created new category with child access level
5. Created new category menu item for the child category

Can see child category with child access level in the category form field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40193.

avatar Quy Quy - test_item - 28 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 28 Mar 2023

I have tested this item successfully on c63878c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40193.

avatar Quy Quy - change - 28 Mar 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 28 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40193.

avatar obuisard obuisard - change - 4 May 2023
Labels Added: ? bug
avatar obuisard obuisard - change - 5 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-05 00:28:40
Closed_By obuisard
avatar obuisard obuisard - close - 5 May 2023
avatar obuisard obuisard - merge - 5 May 2023
avatar obuisard
obuisard - comment - 5 May 2023

Thank you Tuan @joomdonation for the PR!

Add a Comment

Login with GitHub to post a comment