[#40168] - [4.3] RSS Feed title
- Fixed in Code Base
- 12 May 2023
- Medium
- Build: 4.3-dev
- # 40168
- Diff
- brianteeman:rss_feed
User tests: Successful: Unsuccessful:
Pull Request for Issue #40123 .
Summary of Changes
add a meaningful title to the feed by using the document page title
Testing Instructions
Create the following menu items
Blog Category
Featured Articles
Tags (List All)
Contacts (list)
Add page titles to some of them
Actual result BEFORE applying this Pull Request
If you view the source you will find the following in the header
<link href="seite.feed?type=rss" rel="alternate" type="application/rss+xml" title="RSS 2.0">
<link href="seite.feed?type=atom" rel="alternate" type="application/atom+xml" title="Atom 1.0">
Expected result AFTER applying this Pull Request
<link href="seite.feed?type=rss" rel="alternate" type="application/rss+xml" title="xxxxxxxxxx">
<link href="seite.feed?type=atom" rel="alternate" type="application/atom+xml" title="xxxxxxxx">
Where xxxxxxxx is the page title according to the settings so it is the same as the browser page title eg
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End com_content com_finder com_tags Libraries |
| Status | New | ⇒ | Pending |
Should escape title just in case it contains an ".
<link href="/joomla-cms-4.3-dev/index.php/all-tags?format=feed&type=rss" rel="alternate" type="application/rss+xml" title="All "Tags"">
| Labels |
Added:
PR-4.3-dev
|
||
Should escape title just in case it contains an
".<link href="/joomla-cms-4.3-dev/index.php/all-tags?format=feed&type=rss" rel="alternate" type="application/rss+xml" title="All "Tags"">
This should be done in the renderer and not here.
and that would be where?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40168.
I have tested this item
Tested successfully! 6137e4d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40168.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40168.
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-12 17:38:24 |
| Closed_By | ⇒ | obuisard |
Thank you Brian @brianteeman !
Thanks
I have tested this item✅ successfully on 630886d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40168.